From nobody Tue Feb 10 01:59:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618499345; cv=none; d=zohomail.com; s=zohoarc; b=F/vbNYIei/zDoJDOv1IIsWsgaHEHIbIfD6p4DjHLYnR5IgPFcTyiXP7p5esFqARPCsVFZZ85+xCnleGYD7IcZ5+nqpolQTN/dIBoecn/RVT6UZbaxxV6jaTuy5RSzdv3CelmC2wO9boRccpRDe2cpqDDH0DaFr7QSnw75ySSKnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618499345; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5VEWRZq0mknWmuHx/bylk1ilUKpbiQLj/0qB/evn6Q4=; b=j++w+WES4iNNP8MkrhG00JQBNyJ0FQVDK1jhCG3EqeMqAQfgYiXiDGJ2gWDOG8tDP1vhF0MYwNaKyNqrjQjfEVQsyfPhDoBu1YgpSVDqOp7xI7teiN7GiQqTgsMTj6e+iJwUg46NgTgYGbwCjhh37gQ/nNqHOfzTUhmsBkzOpYs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618499345406860.4957437089253; Thu, 15 Apr 2021 08:09:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-wJk1o56gPf6AQNL6Q5Tc6g-1; Thu, 15 Apr 2021 11:08:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3ECA7108BC2E; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 176FE6064B; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7E56E1806D16; Thu, 15 Apr 2021 15:08:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13FF8WS1029778 for ; Thu, 15 Apr 2021 11:08:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 22D0460917; Thu, 15 Apr 2021 15:08:32 +0000 (UTC) Received: from work.redhat.com (ovpn-114-212.ams2.redhat.com [10.36.114.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65F6160CC5; Thu, 15 Apr 2021 15:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618499343; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5VEWRZq0mknWmuHx/bylk1ilUKpbiQLj/0qB/evn6Q4=; b=ZMw3hsHLh1R62dNEnIlxY4BaDn0vWg8MaQAwah/ZB+dOdmTaS0zQk0AiV8CBJmIEyjoRjX D7AdNaXmx8qUKHJnn6CacHuc+2Gk8caRCRfxzYh0pJpLlXz7qWi8xVFYRhBb5i9Wc/fvkp vYVqAGjaePtnz/7kzGQkigU1pbkatUc= X-MC-Unique: wJk1o56gPf6AQNL6Q5Tc6g-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak Date: Thu, 15 Apr 2021 17:08:27 +0200 Message-Id: <20210415150828.134760-3-twiederh@redhat.com> In-Reply-To: <20210415150828.134760-1-twiederh@redhat.com> References: <20210415150828.134760-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 029f2d8d9c..5591681283 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18994,12 +18994,12 @@ virDomainFeaturesDefParse(virDomainDef *def, int feature; int value; g_autofree char *ptval =3D NULL; - g_autofree char *tmp =3D NULL; =20 if ((n =3D virXPathNodeSet("./features/xen/*", ctxt, &nodes)) < 0) return -1; =20 for (i =3D 0; i < n; i++) { + g_autofree char *tmp =3D NULL; feature =3D virDomainXenTypeFromString((const char *)nodes[i]-= >name); if (feature < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, --=20 2.26.2