util: Fix error reporting in virnetlink

[libvirt PATCH] util: Fix error reporting in virnetlink

Andrea Bolognani posted 1 patch 3 years, 1 month ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210309102228.8653-1-abologna@redhat.com

src/util/virnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] util: Fix error reporting in virnetlink

Posted by Andrea Bolognani 3 years, 1 month ago

The preprocessor macro we use to check whether we're on Linux
has not been spelled properly, and so we will always report the
error message intended for other platforms.

Fixes: 879bcee08ce0f91f556fddfe452c3fbed5318468
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/util/virnetlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
index a06195bd00..cfb86550a5 100644
--- a/src/util/virnetlink.c
+++ b/src/util/virnetlink.c
@@ -1231,7 +1231,7 @@ virNetlinkEventRemoveClient(int watch, const virMacAddr *macaddr,
 
 #else
 
-# if defined(__linux)
+# if defined(__linux__)
 static const char *unsupported = N_("libnl was not available at build time");
 # else
 static const char *unsupported = N_("not supported on non-linux platforms");
-- 
2.26.2

Re: [libvirt PATCH] util: Fix error reporting in virnetlink

Posted by Michal Privoznik 3 years, 1 month ago

On 3/9/21 11:22 AM, Andrea Bolognani wrote:
> The preprocessor macro we use to check whether we're on Linux
> has not been spelled properly, and so we will always report the
> error message intended for other platforms.
> 
> Fixes: 879bcee08ce0f91f556fddfe452c3fbed5318468
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>   src/util/virnetlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
> index a06195bd00..cfb86550a5 100644
> --- a/src/util/virnetlink.c
> +++ b/src/util/virnetlink.c
> @@ -1231,7 +1231,7 @@ virNetlinkEventRemoveClient(int watch, const virMacAddr *macaddr,
>   
>   #else
>   
> -# if defined(__linux)
> +# if defined(__linux__)
>   static const char *unsupported = N_("libnl was not available at build time");
>   # else
>   static const char *unsupported = N_("not supported on non-linux platforms");
> 

LOL

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal