From nobody Mon May 6 08:31:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615285374; cv=none; d=zohomail.com; s=zohoarc; b=bYwbt9sxksIdsBBbRMkbRXOF8j9t+QYHXAygc/HCRrI6xaA31RYwJ19oVfRk/KQ3X3e+xAJOWRYJychyYk28Jd8nAJIY2/qro49/tjMhY7cnprQSVGAFc8nQTOae2yQ7pbMjFt3oK0tBaDQQFutI2YoHmk0AqBZjFD5mIoDcEDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615285374; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JEblVtdLmgWgqXREoG/f2Jlu5WZCx5j/aQZOXs0u31c=; b=K3mD+kgjkD+F5faDGQGVAOiH6AQOBkv03XCRXpRcE70uEvG6cxO01oeB4RYzvxW24ula43dVBB60yx01k43ZfENZ0DemsxVZiWVkXvvfxBx/xPIk0c8SrF6PuUv08algr10pyuW9hvMWPPchRPW85dgA2Sllu2ac20bt1bkVpVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1615285374091137.45769062119302; Tue, 9 Mar 2021 02:22:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-czTWoZYtPRyfoKyGIYtTiw-1; Tue, 09 Mar 2021 05:22:51 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F330B801814; Tue, 9 Mar 2021 10:22:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 398945C6B8; Tue, 9 Mar 2021 10:22:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 87C444ED86; Tue, 9 Mar 2021 10:22:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 129AMZ5D023956 for ; Tue, 9 Mar 2021 05:22:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id A3B3A5D9DC; Tue, 9 Mar 2021 10:22:35 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.196.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DBE085D9E3 for ; Tue, 9 Mar 2021 10:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615285373; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JEblVtdLmgWgqXREoG/f2Jlu5WZCx5j/aQZOXs0u31c=; b=URlOkMChNHiBeEk+D7aiIHSNizvCOiwscpRT/EGRZEhm3LCsRhzUa71/fN333MeZYLLhW9 vYe7vyU2emg230pNndTmJEk0KMkjtEGoWKnp3PEhZDTaIiBoo1DY2aT5OQny9ZCD1GhVNF NS0sYaEUTsnuS5z6sVm+ygbDJ9GfYGg= X-MC-Unique: czTWoZYtPRyfoKyGIYtTiw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] util: Fix error reporting in virnetlink Date: Tue, 9 Mar 2021 11:22:28 +0100 Message-Id: <20210309102228.8653-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The preprocessor macro we use to check whether we're on Linux has not been spelled properly, and so we will always report the error message intended for other platforms. Fixes: 879bcee08ce0f91f556fddfe452c3fbed5318468 Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/util/virnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index a06195bd00..cfb86550a5 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -1231,7 +1231,7 @@ virNetlinkEventRemoveClient(int watch, const virMacAd= dr *macaddr, =20 #else =20 -# if defined(__linux) +# if defined(__linux__) static const char *unsupported =3D N_("libnl was not available at build ti= me"); # else static const char *unsupported =3D N_("not supported on non-linux platform= s"); --=20 2.26.2