[v1] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

[PATCH 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Laine Stump posted 7 patches 3 years, 4 months ago

Diff against v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201209013745.599662-1-laine@redhat.com

There is a newer version of this series

src/qemu/qemu_domain_address.c |  43 ++-----------
src/util/virpci.c              | 107 ++++++++++++++++++++++++---------
2 files changed, 82 insertions(+), 68 deletions(-)

Expand all Fold all

[PATCH 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Posted by Laine Stump 3 years, 4 months ago

I think there's an adequate description in patch 6 (and maybe in the
bugzilla record: https://bugzilla.redhat.com/1901685). I already typed
a long description once, and git send-email failed due to network
problems and threw away everything I typed. I don't feel like typing
it again.

Laine Stump (7):
  qemu: use g_autoptr for a virPCIDevice
  util: simplify calling of virPCIDeviceDetectFunctionLevelReset()
  util: simplify call to virPCIDeviceDetectPowerManagementReset()
  util: make read error of PCI config file more detailed
  util: change call sequence for virPCIDeviceFindCapabilityOffset()
  util: make virPCIDeviceIsPCIExpress() more intelligent
  qemu: remove now-redundant check for file length when determining PCIe
    vs. PCI

 src/qemu/qemu_domain_address.c |  43 ++-----------
 src/util/virpci.c              | 107 ++++++++++++++++++++++++---------
 2 files changed, 82 insertions(+), 68 deletions(-)

-- 
2.28.0

Re: [PATCH 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Posted by Michal Privoznik 3 years, 4 months ago

On 12/9/20 2:37 AM, Laine Stump wrote:
> I think there's an adequate description in patch 6 (and maybe in the
> bugzilla record: https://bugzilla.redhat.com/1901685). I already typed
> a long description once, and git send-email failed due to network
> problems and threw away everything I typed. I don't feel like typing
> it again.
> 
> Laine Stump (7):
>    qemu: use g_autoptr for a virPCIDevice
>    util: simplify calling of virPCIDeviceDetectFunctionLevelReset()
>    util: simplify call to virPCIDeviceDetectPowerManagementReset()
>    util: make read error of PCI config file more detailed
>    util: change call sequence for virPCIDeviceFindCapabilityOffset()
>    util: make virPCIDeviceIsPCIExpress() more intelligent
>    qemu: remove now-redundant check for file length when determining PCIe
>      vs. PCI
> 
>   src/qemu/qemu_domain_address.c |  43 ++-----------
>   src/util/virpci.c              | 107 ++++++++++++++++++++++++---------
>   2 files changed, 82 insertions(+), 68 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal