[v2] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

[libvirt PATCH v2 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Laine Stump posted 7 patches 3 years, 4 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201211154728.1117948-1-laine@redhat.com

src/qemu/qemu_domain_address.c |  43 +--------
src/util/virpci.c              | 166 +++++++++++++++++++++++++++------
2 files changed, 141 insertions(+), 68 deletions(-)

Expand all Fold all

[libvirt PATCH v2 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Posted by Laine Stump 3 years, 4 months ago

danpb had asked for some documentation on the changes to the APIs of
internal functions in V1. I've added some standard function header
docs in patches 5 & 6. Everything else is completely unchanged (and
already reviewed by mprivozn).

Laine Stump (7):
  qemu: use g_autoptr for a virPCIDevice
  util: simplify calling of virPCIDeviceDetectFunctionLevelReset()
  util: simplify call to virPCIDeviceDetectPowerManagementReset()
  util: make read error of PCI config file more detailed
  util: change call sequence for virPCIDeviceFindCapabilityOffset()
  util: make virPCIDeviceIsPCIExpress() more intelligent
  qemu: remove now-redundant check for file length when determining PCIe
    vs. PCI

 src/qemu/qemu_domain_address.c |  43 +--------
 src/util/virpci.c              | 166 +++++++++++++++++++++++++++------
 2 files changed, 141 insertions(+), 68 deletions(-)

-- 
2.28.0

Re: [libvirt PATCH v2 0/7] fix PCI vs PCIe detection when running libvirtd as root, but unprivileged

Posted by Michal Privoznik 3 years, 4 months ago

On 12/11/20 4:47 PM, Laine Stump wrote:
> danpb had asked for some documentation on the changes to the APIs of
> internal functions in V1. I've added some standard function header
> docs in patches 5 & 6. Everything else is completely unchanged (and
> already reviewed by mprivozn).
> 
> Laine Stump (7):
>    qemu: use g_autoptr for a virPCIDevice
>    util: simplify calling of virPCIDeviceDetectFunctionLevelReset()
>    util: simplify call to virPCIDeviceDetectPowerManagementReset()
>    util: make read error of PCI config file more detailed
>    util: change call sequence for virPCIDeviceFindCapabilityOffset()
>    util: make virPCIDeviceIsPCIExpress() more intelligent
>    qemu: remove now-redundant check for file length when determining PCIe
>      vs. PCI
> 
>   src/qemu/qemu_domain_address.c |  43 +--------
>   src/util/virpci.c              | 166 +++++++++++++++++++++++++++------
>   2 files changed, 141 insertions(+), 68 deletions(-)
>

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal