Commit f7114e61db removed these lines as being "old and
obsolete". cscope may be old, but it is still very much useful and
used (i.e. *not* obsolete), and having the files show up as "Untracked
files:" every time git status is run is annoying.

Signed-off-by: Laine Stump <laine@redhat.com>
---

I'm not sure why I didn't notice this omission until now, but a couple
weeks ago it resulted in my accidentally committing my cscope.out and
cscope.files to git (fortunately I noticed it before I posted the
patch!)

It could be argued (as abologna did on IRC) that users should just add
these to their private user-global .gitignore, but if that's the case,
then the vim and emacs-related files should also be removed from
libvirt's .gitignore (also suggested by abologna :-)).

However if you do that, then any time you checkout libvirt on some
random new machine where you haven't imported your personal home
directory template will end up showing these by-product files. Also,
somebody newly entering the project will potentially have the files
showing up and bothering them.

Anyway, I'm not necessarily advocating for re-adding the cscope files,
but sending a patch seemed to be like the most useful way of
discussing it.

 .gitignore | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.gitignore b/.gitignore
index 6d44a50061..feb2bcb017 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,6 +8,12 @@
 .#*
 *~
 
+# cscope related ignores
+cscope.files
+cscope.in.out
+cscope.out
+cscope.po.out
+
 # git related ignores
 *.rej
 *.orig
-- 
2.26.2

On 10/27/20 5:39 PM, Laine Stump wrote:
> Commit f7114e61db removed these lines as being "old and
> obsolete". cscope may be old, but it is still very much useful and
> used (i.e. *not* obsolete), and having the files show up as "Untracked
> files:" every time git status is run is annoying.
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
> 
> I'm not sure why I didn't notice this omission until now, but a couple
> weeks ago it resulted in my accidentally committing my cscope.out and
> cscope.files to git (fortunately I noticed it before I posted the
> patch!)
> 
> It could be argued (as abologna did on IRC) that users should just add
> these to their private user-global .gitignore, but if that's the case,
> then the vim and emacs-related files should also be removed from
> libvirt's .gitignore (also suggested by abologna :-)).
> 
> However if you do that, then any time you checkout libvirt on some
> random new machine where you haven't imported your personal home
> directory template will end up showing these by-product files. Also,
> somebody newly entering the project will potentially have the files
> showing up and bothering them.
> 
> Anyway, I'm not necessarily advocating for re-adding the cscope files,
> but sending a patch seemed to be like the most useful way of
> discussing it.
> 
>   .gitignore | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 6d44a50061..feb2bcb017 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -8,6 +8,12 @@
>   .#*
>   *~
>   
> +# cscope related ignores
> +cscope.files
> +cscope.in.out
> +cscope.out
> +cscope.po.out
> +
>   # git related ignores
>   *.rej
>   *.orig
> 

Since this is not a technical question but a matter of preference, I 
won't put my ACK rather than +1. We already have vim/emacs files 
ignored, tags (marked as "libvirt related ignores" - wut?), /build/ 
(why, if I need to provide a builddir every time? and just so you know, 
I'm providing _build). If some of us use cscope we should add these files.

Michal