From nobody Fri May 3 07:06:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603817325; cv=none; d=zohomail.com; s=zohoarc; b=D2iAA3ZWEEMUxOj6RgjwBaEZPHRqkUNRDsRsi0erUEu/F7gMPVHZiLG+T44lUrYVL89kigtJ9GvwRMqxgIWxFi3Y7s1qu8Squ8xNCpMUVwwMdZ+QGVT5VdYuMV4jUw6ugsiBivsTCm5HtHlWZP9RV6dx2i9zfcpJ4S/RXyme48E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603817325; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IV8AuhDpC7QX4V3owr14+fxOuw5JBRpQUpapteXc1UQ=; b=F1VmjoOtFDUktl/qf/mLPUhEZTJPH/cXmoFGVG9n7Fel8H2AYclCGysRN+KUNiLCSRGO9BQV9WQ5nP5w+AwelSrVHm2mGM3pQ87nCR2EcM/1BaZlkVwkMkDwjPrOt63+Pstbj4uhFL+/3XG4sKbtxWlRxzmoPbL9fid3E9eKR3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1603817325217267.2526105895066; Tue, 27 Oct 2020 09:48:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-ozWN9TtaMP-e7EmweYOdbg-1; Tue, 27 Oct 2020 12:48:39 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F8E61019635; Tue, 27 Oct 2020 16:48:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B11762C31E; Tue, 27 Oct 2020 16:48:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 964F51832FC2; Tue, 27 Oct 2020 16:48:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09RGdZDs018824 for ; Tue, 27 Oct 2020 12:39:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3CF2860C47; Tue, 27 Oct 2020 16:39:35 +0000 (UTC) Received: from vhost2.laine.org (ovpn-113-144.phx2.redhat.com [10.3.113.144]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2B2060FC2 for ; Tue, 27 Oct 2020 16:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603817323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IV8AuhDpC7QX4V3owr14+fxOuw5JBRpQUpapteXc1UQ=; b=iZoBmXJw28DFFVw6ODyOjoAnCHWnS7cnDnKAD+USKmWQoxsw1rVDrMK3r6FW1Le55gadgo k+tC9KpfU3fEC6DboxU+VPtYqfx84o2iIryH1dkLrcxUyI+nxawAyOS/nZYfzLMfdrbp9i quaL5ayjdC99BOuNSGKgk61RgkEiICM= X-MC-Unique: ozWN9TtaMP-e7EmweYOdbg-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH] re-add cscope db files to .gitignore Date: Tue, 27 Oct 2020 12:39:27 -0400 Message-Id: <20201027163927.298971-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit f7114e61db removed these lines as being "old and obsolete". cscope may be old, but it is still very much useful and used (i.e. *not* obsolete), and having the files show up as "Untracked files:" every time git status is run is annoying. Signed-off-by: Laine Stump --- I'm not sure why I didn't notice this omission until now, but a couple weeks ago it resulted in my accidentally committing my cscope.out and cscope.files to git (fortunately I noticed it before I posted the patch!) It could be argued (as abologna did on IRC) that users should just add these to their private user-global .gitignore, but if that's the case, then the vim and emacs-related files should also be removed from libvirt's .gitignore (also suggested by abologna :-)). However if you do that, then any time you checkout libvirt on some random new machine where you haven't imported your personal home directory template will end up showing these by-product files. Also, somebody newly entering the project will potentially have the files showing up and bothering them. Anyway, I'm not necessarily advocating for re-adding the cscope files, but sending a patch seemed to be like the most useful way of discussing it. .gitignore | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.gitignore b/.gitignore index 6d44a50061..feb2bcb017 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,12 @@ .#* *~ =20 +# cscope related ignores +cscope.files +cscope.in.out +cscope.out +cscope.po.out + # git related ignores *.rej *.orig --=20 2.26.2