[libvirt PATCH 3/9] spec: bash completion actually defaults to on

Andrea Bolognani posted 9 patches 5 years, 4 months ago
There is a newer version of this series
[libvirt PATCH 3/9] spec: bash completion actually defaults to on
Posted by Andrea Bolognani 5 years, 4 months ago
Remove the red herring.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4572044d2d..9e4c5d2b81 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -84,6 +84,9 @@
     %define with_storage_iscsi_direct 0
 %endif
 
+# Other optional features
+%define with_bash_completion  0%{!?_without_bash_completion:1}
+
 # A few optional bits off by default, we enable later
 %define with_fuse             0
 %define with_sanlock          0
@@ -92,7 +95,6 @@
 %define with_libssh2          0
 %define with_wireshark        0
 %define with_libssh           0
-%define with_bash_completion  0
 
 # Finally set the OS / architecture specific special cases
 
@@ -174,8 +176,6 @@
     %define with_libssh 0%{!?_without_libssh:1}
 %endif
 
-%define with_bash_completion  0%{!?_without_bash_completion:1}
-
 %if %{with_qemu} || %{with_lxc}
 # numad is used to manage the CPU and memory placement dynamically,
 # it's not available on many non-x86 architectures.
-- 
2.26.2

Re: [libvirt PATCH 3/9] spec: bash completion actually defaults to on
Posted by Neal Gompa 5 years, 4 months ago
On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> Remove the red herring.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 4572044d2d..9e4c5d2b81 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -84,6 +84,9 @@
>      %define with_storage_iscsi_direct 0
>  %endif
>
> +# Other optional features
> +%define with_bash_completion  0%{!?_without_bash_completion:1}
> +
>  # A few optional bits off by default, we enable later
>  %define with_fuse             0
>  %define with_sanlock          0
> @@ -92,7 +95,6 @@
>  %define with_libssh2          0
>  %define with_wireshark        0
>  %define with_libssh           0
> -%define with_bash_completion  0
>
>  # Finally set the OS / architecture specific special cases
>
> @@ -174,8 +176,6 @@
>      %define with_libssh 0%{!?_without_libssh:1}
>  %endif
>
> -%define with_bash_completion  0%{!?_without_bash_completion:1}
> -
>  %if %{with_qemu} || %{with_lxc}
>  # numad is used to manage the CPU and memory placement dynamically,
>  # it's not available on many non-x86 architectures.
> --
> 2.26.2
>

This is more crappy fake-%bcond goop, except in the other direction...

-- 
真実はいつも一つ!/ Always, there's only one truth!