[v2] spec: Improve feature and architecture handling

[libvirt PATCH v2 0/9] spec: Improve feature and architecture handling

Andrea Bolognani posted 9 patches 3 years, 6 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201009092546.15546-1-abologna@redhat.com

libvirt.spec.in | 116 ++++++++++++++++++++++++------------------------
1 file changed, 57 insertions(+), 59 deletions(-)

Expand all Fold all

[libvirt PATCH v2 0/9] spec: Improve feature and architecture handling

Posted by Andrea Bolognani 3 years, 6 months ago

Changes from [v1]:

  * address review feedback.

[v1] https://www.redhat.com/archives/libvir-list/2020-October/msg00336.html

Andrea Bolognani (9):
  spec: Simplify setting features off by default
  spec: firewalld is always enabled
  spec: bash completion actually defaults to on
  spec: Move with_numactl definition
  spec: Introduce with_dmidecode
  spec: Move _vpath_builddir definition
  spec: Drop s390 architecture from conditionals
  spec: Refactor qemu_kvm_arches definition
  spec: Introduce arches_*

 libvirt.spec.in | 116 ++++++++++++++++++++++++------------------------
 1 file changed, 57 insertions(+), 59 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH v2 0/9] spec: Improve feature and architecture handling

Posted by Neal Gompa 3 years, 6 months ago

On Fri, Oct 9, 2020 at 5:27 AM Andrea Bolognani <abologna@redhat.com> wrote:
>
> Changes from [v1]:
>
>   * address review feedback.
>
> [v1] https://www.redhat.com/archives/libvir-list/2020-October/msg00336.html
>
> Andrea Bolognani (9):
>   spec: Simplify setting features off by default
>   spec: firewalld is always enabled
>   spec: bash completion actually defaults to on
>   spec: Move with_numactl definition
>   spec: Introduce with_dmidecode
>   spec: Move _vpath_builddir definition
>   spec: Drop s390 architecture from conditionals
>   spec: Refactor qemu_kvm_arches definition
>   spec: Introduce arches_*
>
>  libvirt.spec.in | 116 ++++++++++++++++++++++++------------------------
>  1 file changed, 57 insertions(+), 59 deletions(-)
>
> --
> 2.26.2
>
>

Series LGTM.

Reviewed-by: Neal Gompa <ngompa13@gmail.com>


-- 
真実はいつも一つ！/ Always, there's only one truth!