On Sat, Sep 12, 2020 at 12:48:13PM +0200, Ján Tomko wrote:
> On a Friday in 2020, Lin Ma wrote:
> > Signed-off-by: Lin Ma <lma@suse.de>
> > ---
> > docs/manpages/virsh.rst | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> > index ca5acf84ca..b8206205f6 100644
> > --- a/docs/manpages/virsh.rst
> > +++ b/docs/manpages/virsh.rst
> > @@ -4521,7 +4521,8 @@ within the existing virtual cdrom or floppy device; consider using
> > *sourcetype* can indicate the type of source (block|file)
> > *cache* can be one of "default", "none", "writethrough", "writeback",
> > "directsync" or "unsafe".
> > -*io* controls specific policies on I/O; QEMU guests support "threads" and "native".
> > +*io* controls specific policies on I/O; QEMU guests support "threads",
> > +"native", "io_uring" since kernel 5.1 and qemu 5.0.
I don't see why we should mention the specific versions in the manpage for the
client, it should be documented on the backend side IOW libvirt docs. The
client just gets support for a new feature, everything else doesn't need to
concern it IMO, so I'd just go simply with "io_uring" and by that you also drop
the ambiguity Jano mentioned.
Erik
>
> Threads and native were supported even with older QEMUs and kernels.
> The phrasing here looks ambiguous.
>
> Jano
>
> > *iothread* is the number within the range of domain IOThreads to which
> > this disk may be attached (QEMU only).
> > *serial* is the serial of disk device. *wwn* is the wwn of disk device.
> > --
> > 2.26.0
> >