[libvirt PATCH] spec: Drop explicit dependency on ncurses

Andrea Bolognani posted 1 patch 3 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200718225443.36349-1-abologna@redhat.com
libvirt.spec.in | 2 --
1 file changed, 2 deletions(-)
[libvirt PATCH] spec: Drop explicit dependency on ncurses
Posted by Andrea Bolognani 3 years, 9 months ago
We don't actually use ncurses directly: readline needs it, but
that's a readline implementation detail and not something that we
should concern ourselves with.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Test pipeline where I've tweaked all CI environments so that ncurses
is not explicitly installed, and in the case of macOS pkg-config is
not configured in a way that allows it to locate ncurses.pc:

  https://gitlab.com/abologna/libvirt/-/pipelines/168175622

 libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f335a7e06e..029159269b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -288,7 +288,6 @@ BuildRequires: readline-devel
 %if %{with_bash_completion}
 BuildRequires: bash-completion >= 2.0
 %endif
-BuildRequires: ncurses-devel
 BuildRequires: gettext
 BuildRequires: libtasn1-devel
 BuildRequires: gnutls-devel
@@ -901,7 +900,6 @@ capabilities of VirtualBox
 Summary: Client side utilities of the libvirt library
 Requires: %{name}-libs = %{version}-%{release}
 Requires: readline
-Requires: ncurses
 # Needed by /usr/libexec/libvirt-guests.sh script.
 Requires: gettext
 # Needed by virt-pki-validate script.
-- 
2.25.4

Re: [libvirt PATCH] spec: Drop explicit dependency on ncurses
Posted by Erik Skultety 3 years, 9 months ago
On Sun, Jul 19, 2020 at 12:54:43AM +0200, Andrea Bolognani wrote:
> We don't actually use ncurses directly: readline needs it, but
> that's a readline implementation detail and not something that we
> should concern ourselves with.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> Test pipeline where I've tweaked all CI environments so that ncurses
> is not explicitly installed, and in the case of macOS pkg-config is
> not configured in a way that allows it to locate ncurses.pc:
>
>   https://gitlab.com/abologna/libvirt/-/pipelines/168175622
>
>  libvirt.spec.in | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Erik Skultety <eskultet@redhat.com>