From nobody Thu May 2 11:54:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595113133; cv=none; d=zohomail.com; s=zohoarc; b=c72lgeZMoqZqvdoaIa94JgWcI0rJxw5QN8J88r7yUph3Eu/rS7027SVpbgYB4jZQGuTdphi20M5r/DTmV0s50f73vGa3XMtFufBNma3BI7J3xFjqi9oDvPnHPtqcmWNMJcvSHhwjMl+ql8jo+eWWNYN2iuqVtcsobqTWE0UPajo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595113133; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fOAB6exvtKLNRuVRqwnLsc37e5/c4oDqJb51LWEdPTg=; b=aFjnIy2G03+uHAUYlndSW7jSrdTInT81YgF2sI5E0P1uLnf5yrLXOC+b//9csnKvqVRreB1lAUDftWGR66B7+OFvYG4QvzDqROGJJfpkRUdFdL+fmsY1yMW7Ct13zGQeBkIR5n5kLelzwx94Ao6OUiLZG5FCPnBUbb2QGCUFUr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1595113133868717.4657723399956; Sat, 18 Jul 2020 15:58:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-F17_E1TMO8m1v-Dt8Xuj6Q-1; Sat, 18 Jul 2020 18:58:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D43480183C; Sat, 18 Jul 2020 22:58:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E405B5D9E7; Sat, 18 Jul 2020 22:58:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 71AEE94EE5; Sat, 18 Jul 2020 22:58:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06IMsn8x013574 for ; Sat, 18 Jul 2020 18:54:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6A76560BE2; Sat, 18 Jul 2020 22:54:49 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.192.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B153D60E3E for ; Sat, 18 Jul 2020 22:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595113132; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fOAB6exvtKLNRuVRqwnLsc37e5/c4oDqJb51LWEdPTg=; b=V8Sx1f7x+BE8yIcN0C3AQOEl+qkC8kEhfnxU0larpHzM5i0b8suE0LfBr+EluzCZNMH6BF ZoULSIR7UlM7NgFXwlBlOggKRVqC+Nlfx52dk6OdSMUsmOnD2KPfd202Tka9URUrG23nnF WDMS3IJ5p3/I3m7pWBhaXIcEubjXmwM= X-MC-Unique: F17_E1TMO8m1v-Dt8Xuj6Q-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] spec: Drop explicit dependency on ncurses Date: Sun, 19 Jul 2020 00:54:43 +0200 Message-Id: <20200718225443.36349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We don't actually use ncurses directly: readline needs it, but that's a readline implementation detail and not something that we should concern ourselves with. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- Test pipeline where I've tweaked all CI environments so that ncurses is not explicitly installed, and in the case of macOS pkg-config is not configured in a way that allows it to locate ncurses.pc: https://gitlab.com/abologna/libvirt/-/pipelines/168175622 libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f335a7e06e..029159269b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -288,7 +288,6 @@ BuildRequires: readline-devel %if %{with_bash_completion} BuildRequires: bash-completion >=3D 2.0 %endif -BuildRequires: ncurses-devel BuildRequires: gettext BuildRequires: libtasn1-devel BuildRequires: gnutls-devel @@ -901,7 +900,6 @@ capabilities of VirtualBox Summary: Client side utilities of the libvirt library Requires: %{name}-libs =3D %{version}-%{release} Requires: readline -Requires: ncurses # Needed by /usr/libexec/libvirt-guests.sh script. Requires: gettext # Needed by virt-pki-validate script. --=20 2.25.4