always use g_auto() for virBuffer and virFirewall objects

[PATCH 16/32] qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer()

Posted by Laine Stump 5 years, 7 months ago

The latter function is guaranteed to always clear out the virBuffer
anyway, so this is redundant and could add to extra cargo-cult code if
used as an example.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 src/qemu/qemu_command.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 789c5b8f56..73c6997a49 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8913,7 +8913,6 @@ qemuBuldDomainLoaderPflashCommandLine(virCommandPtr cmd,
     virCommandAddArgBuffer(cmd, &buf);
 
     if (loader->nvram) {
-        virBufferFreeAndReset(&buf);
         virBufferAddLit(&buf, "file=");
         virQEMUBuildBufferEscapeComma(&buf, loader->nvram);
         virBufferAsprintf(&buf, ",if=pflash,format=raw,unit=%d", unit);
-- 
2.25.4

Re: [PATCH 16/32] qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer()

Posted by Ján Tomko 5 years, 7 months ago

On a Sunday in 2020, Laine Stump wrote:
>The latter function is guaranteed to always clear out the virBuffer
>anyway, so this is redundant and could add to extra cargo-cult code if
>used as an example.
>
>Signed-off-by: Laine Stump <laine@redhat.com>
>---
> src/qemu/qemu_command.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano