From nobody Mon Feb 9 19:06:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594006954; cv=none; d=zohomail.com; s=zohoarc; b=VJEYMfDO6jT44ioU8PUCJ72rO6rcOUXXkR2WydXvUmOBDx24M2Ny5E4ZjSfKYQ2LxI5mZgtIGhOKEQ7T6FbzyA/VQGThCPsvtla0UURU2qe1OdWNckSjtzKSeInYWFkpnKYVGkVOpBuKLeuW4ABGMK5CAzUwu6I0CxIfl+k5uxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594006954; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kvvwQnTxAgJx0ZMTSspTEfQWfklcp1/juAviCM4CCXM=; b=UxZUB+79QGTpEeQ4tOJX1xHQaiBOhsYgwR3POGie8EP/44BQch0cBmToWEuIrtuEC2M9LtoPIA2iC5veTQBFztK58sW+fFa6tA+zgDMwNWd3rslEzlAt+b8xs/jaD1y7KeHbaQtZPqMLWk8gqURUYaH3QjANJH9oIlPz448n05k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1594006954121597.4602139592884; Sun, 5 Jul 2020 20:42:34 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-cooe-wFEPmKdZQr8oRw10w-1; Sun, 05 Jul 2020 23:42:30 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5800C64AE8; Mon, 6 Jul 2020 03:42:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A5C55C1D4; Mon, 6 Jul 2020 03:42:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0C3E91805310; Mon, 6 Jul 2020 03:42:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0663fmUW004537 for ; Sun, 5 Jul 2020 23:41:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id 63736129F95; Mon, 6 Jul 2020 03:41:48 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-194.phx2.redhat.com [10.3.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 183777AC9F for ; Mon, 6 Jul 2020 03:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594006952; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kvvwQnTxAgJx0ZMTSspTEfQWfklcp1/juAviCM4CCXM=; b=SyIqJpPezr1hej5RJiUhqwdGS8fdKvIsBlHY/3Ousog06NZHbgCm0m+YKL4UinKiGd38wE eSBJSIxHs9kfnymaf3+erenCU7LSmt3OPzTN1vQbsep0uiAlwfP8JpSTC+v52FD8orDxvX 0knslnONi0UIvGDeiHQ9/zPrRt/jmFE= X-MC-Unique: cooe-wFEPmKdZQr8oRw10w-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 16/32] qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer() Date: Sun, 5 Jul 2020 23:41:11 -0400 Message-Id: <20200706034127.1117504-17-laine@redhat.com> In-Reply-To: <20200706034127.1117504-1-laine@redhat.com> References: <20200706034127.1117504-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The latter function is guaranteed to always clear out the virBuffer anyway, so this is redundant and could add to extra cargo-cult code if used as an example. Signed-off-by: Laine Stump Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 789c5b8f56..73c6997a49 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8913,7 +8913,6 @@ qemuBuldDomainLoaderPflashCommandLine(virCommandPtr c= md, virCommandAddArgBuffer(cmd, &buf); =20 if (loader->nvram) { - virBufferFreeAndReset(&buf); virBufferAddLit(&buf, "file=3D"); virQEMUBuildBufferEscapeComma(&buf, loader->nvram); virBufferAsprintf(&buf, ",if=3Dpflash,format=3Draw,unit=3D%d", uni= t); --=20 2.25.4