[v2] remote: fix driver name check for libxl driver

[libvirt PATCH v2] remote: fix driver name check for libxl driver

Daniel P. Berrangé posted 1 patch 3 years, 11 months ago

Diff against v1
Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200504174505.763652-1-berrange@redhat.com

src/remote/remote_daemon_dispatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH v2] remote: fix driver name check for libxl driver

Posted by Daniel P. Berrangé 3 years, 11 months ago

The virConnectGetType() returns "Xen" for libxl, not "LIBXL".

This prevents users opening a connection to the libxl driver when using
the modular daemons.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/remote/remote_daemon_dispatch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index 5d1c6971c0..6f67d2fb30 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -2111,7 +2111,7 @@ remoteDispatchConnectOpen(virNetServerPtr server G_GNUC_UNUSED,
 
     VIR_DEBUG("Primary driver type is '%s'", type);
     if (STREQ(type, "QEMU") ||
-        STREQ(type, "LIBXL") ||
+        STREQ(type, "Xen") ||
         STREQ(type, "LXC") ||
         STREQ(type, "VBOX") ||
         STREQ(type, "bhyve") ||
-- 
2.26.2

Re: [libvirt PATCH v2] remote: fix driver name check for libxl driver

Posted by Jim Fehlig 3 years, 11 months ago

On 5/4/20 11:45 AM, Daniel P. Berrangé wrote:
> The virConnectGetType() returns "Xen" for libxl, not "LIBXL".
> 
> This prevents users opening a connection to the libxl driver when using
> the modular daemons.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim

> ---
>   src/remote/remote_daemon_dispatch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
> index 5d1c6971c0..6f67d2fb30 100644
> --- a/src/remote/remote_daemon_dispatch.c
> +++ b/src/remote/remote_daemon_dispatch.c
> @@ -2111,7 +2111,7 @@ remoteDispatchConnectOpen(virNetServerPtr server G_GNUC_UNUSED,
>   
>       VIR_DEBUG("Primary driver type is '%s'", type);
>       if (STREQ(type, "QEMU") ||
> -        STREQ(type, "LIBXL") ||
> +        STREQ(type, "Xen") ||
>           STREQ(type, "LXC") ||
>           STREQ(type, "VBOX") ||
>           STREQ(type, "bhyve") ||
>