From nobody Fri May 3 05:06:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588614324; cv=none; d=zohomail.com; s=zohoarc; b=AP8suzxUipqOjibiFRYOXL6NK2MX7DUSN1oBI5xPUfBjIhgW39BohNBM/yjxuwKRLWm2c9Mudz+Z8jVHeLrhrRjoHcFpa6a807f1Vw632ECk7Rm6WA6XHB/SnlZiEzSYQy+Wl1nh+1VPy/TbbkE3meIOiYI/hnanKJf9w4cLB2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588614324; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ZrgyYzMNoKqYWQgDB8h2iIa5Z4im4F9fSalwPhX1xpQ=; b=F4YXn2KnyQxbEV2V7a9gR3v9JHSrRAc1w4LHnthrStYDuMVvcTU/2VlBT124RUYF6qqnRn5sgzTELKn23oh8q+MdajKHhF9COAqPPNtBqadrSHNO6Pm7eVm8cDTWhcA6ANFT39t5N1J6z4YW5fu607U9zmJuVxBq5t/1bjZCc/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1588614324401299.0611335155952; Mon, 4 May 2020 10:45:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-xWCh91TzNiCl5qciBmy-8Q-1; Mon, 04 May 2020 13:45:20 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2131DEC1A4; Mon, 4 May 2020 17:45:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E81B55C1D3; Mon, 4 May 2020 17:45:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8B0B64E564; Mon, 4 May 2020 17:45:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 044HjDK1017110 for ; Mon, 4 May 2020 13:45:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1EB9063B8B; Mon, 4 May 2020 17:45:13 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B6E8600F5; Mon, 4 May 2020 17:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588614323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZrgyYzMNoKqYWQgDB8h2iIa5Z4im4F9fSalwPhX1xpQ=; b=AWDgpPEkkc8LaPugXJWVfN6l79Pf+SRBEi+0Pe8iTwYIFPg5FsZ1oZhKqRdKM1UvpWIdjs +QMOz3tDsni+xmGEqXgWpxyX+OviX6gdu1kvm+CBE1cRm7NSGcKC8anWx8eF8R/QuP8Ptv ehF5mTYjJP4YVK++4xVn/vmAiGzdlGw= X-MC-Unique: xWCh91TzNiCl5qciBmy-8Q-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH v2] remote: fix driver name check for libxl driver Date: Mon, 4 May 2020 18:45:05 +0100 Message-Id: <20200504174505.763652-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: PGNet Dev X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The virConnectGetType() returns "Xen" for libxl, not "LIBXL". This prevents users opening a connection to the libxl driver when using the modular daemons. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Jim Fehlig --- src/remote/remote_daemon_dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 5d1c6971c0..6f67d2fb30 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -2111,7 +2111,7 @@ remoteDispatchConnectOpen(virNetServerPtr server G_GN= UC_UNUSED, =20 VIR_DEBUG("Primary driver type is '%s'", type); if (STREQ(type, "QEMU") || - STREQ(type, "LIBXL") || + STREQ(type, "Xen") || STREQ(type, "LXC") || STREQ(type, "VBOX") || STREQ(type, "bhyve") || --=20 2.26.2