[PATCH V3 0/5] Introduce getHost support for ARM CPU driver

ZhengZhenyu posted 5 patches 3 years, 12 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200422071119.2026-1-zheng.zhenyu@foxmail.com
There is a newer version of this series
src/cpu/Makefile.inc.am           |   1 +
src/cpu/cpu.h                     |   2 +
src/cpu/cpu_arm.c                 | 450 +++++++++++++++++++++++++++++-
src/cpu/cpu_arm_data.h            |  31 ++
src/cpu_map/Makefile.inc.am       |   7 +
src/cpu_map/arm_Falkor.xml        |  16 ++
src/cpu_map/arm_Kunpeng-920.xml   |  24 ++
src/cpu_map/arm_ThunderX299xx.xml |  16 ++
src/cpu_map/arm_cortex-a53.xml    |  16 ++
src/cpu_map/arm_cortex-a57.xml    |  15 +
src/cpu_map/arm_cortex-a72.xml    |  15 +
src/cpu_map/arm_vendors.xml       |  14 +
src/cpu_map/index.xml             |  15 +
13 files changed, 619 insertions(+), 3 deletions(-)
create mode 100644 src/cpu/cpu_arm_data.h
create mode 100644 src/cpu_map/arm_Falkor.xml
create mode 100644 src/cpu_map/arm_Kunpeng-920.xml
create mode 100644 src/cpu_map/arm_ThunderX299xx.xml
create mode 100644 src/cpu_map/arm_cortex-a53.xml
create mode 100644 src/cpu_map/arm_cortex-a57.xml
create mode 100644 src/cpu_map/arm_cortex-a72.xml
create mode 100644 src/cpu_map/arm_vendors.xml
[PATCH V3 0/5] Introduce getHost support for ARM CPU driver
Posted by ZhengZhenyu 3 years, 12 months ago
Introduce getHost support for ARM CPU driver. First add
some data about commonly used ARM CPU models, and their
vendors into cpu_map, then added some helper methods as
callbacks to load them. Read and parse vendor_id, part_id
and CPU flags of local CPU from corresponding registers.

Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@gmail.com>

ZhengZhenyu (5):
  cpu_map: Introduce ARM cpu models
  cpu: Introduce virCPUarmData to virCPUData
  cpu: Introduce ARM related structs
  cpu: Add helper funtions to parse vendor and model
  cpu: Introduce getHost support for ARM CPU driver

 src/cpu/Makefile.inc.am           |   1 +
 src/cpu/cpu.h                     |   2 +
 src/cpu/cpu_arm.c                 | 450 +++++++++++++++++++++++++++++-
 src/cpu/cpu_arm_data.h            |  31 ++
 src/cpu_map/Makefile.inc.am       |   7 +
 src/cpu_map/arm_Falkor.xml        |  16 ++
 src/cpu_map/arm_Kunpeng-920.xml   |  24 ++
 src/cpu_map/arm_ThunderX299xx.xml |  16 ++
 src/cpu_map/arm_cortex-a53.xml    |  16 ++
 src/cpu_map/arm_cortex-a57.xml    |  15 +
 src/cpu_map/arm_cortex-a72.xml    |  15 +
 src/cpu_map/arm_vendors.xml       |  14 +
 src/cpu_map/index.xml             |  15 +
 13 files changed, 619 insertions(+), 3 deletions(-)
 create mode 100644 src/cpu/cpu_arm_data.h
 create mode 100644 src/cpu_map/arm_Falkor.xml
 create mode 100644 src/cpu_map/arm_Kunpeng-920.xml
 create mode 100644 src/cpu_map/arm_ThunderX299xx.xml
 create mode 100644 src/cpu_map/arm_cortex-a53.xml
 create mode 100644 src/cpu_map/arm_cortex-a57.xml
 create mode 100644 src/cpu_map/arm_cortex-a72.xml
 create mode 100644 src/cpu_map/arm_vendors.xml

-- 
2.26.0.windows.1


Re: [PATCH V3 0/5] Introduce getHost support for ARM CPU driver
Posted by Zhenyu Zheng 3 years, 11 months ago
ping for reviews

On Wed, Apr 22, 2020 at 3:11 PM ZhengZhenyu <zheng.zhenyu@foxmail.com>
wrote:

> Introduce getHost support for ARM CPU driver. First add
> some data about commonly used ARM CPU models, and their
> vendors into cpu_map, then added some helper methods as
> callbacks to load them. Read and parse vendor_id, part_id
> and CPU flags of local CPU from corresponding registers.
>
> Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@gmail.com>
>
> ZhengZhenyu (5):
>   cpu_map: Introduce ARM cpu models
>   cpu: Introduce virCPUarmData to virCPUData
>   cpu: Introduce ARM related structs
>   cpu: Add helper funtions to parse vendor and model
>   cpu: Introduce getHost support for ARM CPU driver
>
>  src/cpu/Makefile.inc.am           |   1 +
>  src/cpu/cpu.h                     |   2 +
>  src/cpu/cpu_arm.c                 | 450 +++++++++++++++++++++++++++++-
>  src/cpu/cpu_arm_data.h            |  31 ++
>  src/cpu_map/Makefile.inc.am       |   7 +
>  src/cpu_map/arm_Falkor.xml        |  16 ++
>  src/cpu_map/arm_Kunpeng-920.xml   |  24 ++
>  src/cpu_map/arm_ThunderX299xx.xml |  16 ++
>  src/cpu_map/arm_cortex-a53.xml    |  16 ++
>  src/cpu_map/arm_cortex-a57.xml    |  15 +
>  src/cpu_map/arm_cortex-a72.xml    |  15 +
>  src/cpu_map/arm_vendors.xml       |  14 +
>  src/cpu_map/index.xml             |  15 +
>  13 files changed, 619 insertions(+), 3 deletions(-)
>  create mode 100644 src/cpu/cpu_arm_data.h
>  create mode 100644 src/cpu_map/arm_Falkor.xml
>  create mode 100644 src/cpu_map/arm_Kunpeng-920.xml
>  create mode 100644 src/cpu_map/arm_ThunderX299xx.xml
>  create mode 100644 src/cpu_map/arm_cortex-a53.xml
>  create mode 100644 src/cpu_map/arm_cortex-a57.xml
>  create mode 100644 src/cpu_map/arm_cortex-a72.xml
>  create mode 100644 src/cpu_map/arm_vendors.xml
>
> --
> 2.26.0.windows.1
>
>
Re: [PATCH V3 0/5] Introduce getHost support for ARM CPU driver
Posted by Jiri Denemark 3 years, 11 months ago
On Wed, Apr 22, 2020 at 15:11:14 +0800, ZhengZhenyu wrote:
> Introduce getHost support for ARM CPU driver. First add
> some data about commonly used ARM CPU models, and their
> vendors into cpu_map, then added some helper methods as
> callbacks to load them. Read and parse vendor_id, part_id
> and CPU flags of local CPU from corresponding registers.
> 
> Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@gmail.com>

The emails come from ZhengZhenyu <zheng.zhenyu@foxmail.com>, but the
signed-off-by line says something else. Could you make them consistent?

BTW, I'm intentionally replying to v3 as v4 was only supposed to have a
one line diff to v3, but it was sent with both html and plain text parts
and git am was unable to apply any of the v4 patches.

Jirka

Re: [PATCH V3 0/5] Introduce getHost support for ARM CPU driver
Posted by Zhenyu Zheng 3 years, 11 months ago
Hi Jirka,

Thanks alot for the review and suggestions, I will try to fix them. As for
v4, I saw there was a "email patch" button in gitlab, so I used that, so
seems it is not correct :)

BR

On Tue, May 12, 2020 at 11:38 PM Jiri Denemark <jdenemar@redhat.com> wrote:

> On Wed, Apr 22, 2020 at 15:11:14 +0800, ZhengZhenyu wrote:
> > Introduce getHost support for ARM CPU driver. First add
> > some data about commonly used ARM CPU models, and their
> > vendors into cpu_map, then added some helper methods as
> > callbacks to load them. Read and parse vendor_id, part_id
> > and CPU flags of local CPU from corresponding registers.
> >
> > Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@gmail.com>
>
> The emails come from ZhengZhenyu <zheng.zhenyu@foxmail.com>, but the
> signed-off-by line says something else. Could you make them consistent?
>
> BTW, I'm intentionally replying to v3 as v4 was only supposed to have a
> one line diff to v3, but it was sent with both html and plain text parts
> and git am was unable to apply any of the v4 patches.
>
> Jirka
>
Re: [PATCH V3 0/5] Introduce getHost support for ARM CPU driver
Posted by Zhenyu Zheng 3 years, 11 months ago
Thanks alot for the review, I've update the patches as suggested as V5 and
attached the pipeline CI for the last patch to show build results for the
series.

On Wed, May 13, 2020 at 9:09 AM Zhenyu Zheng <zhengzhenyulixi@gmail.com>
wrote:

> Hi Jirka,
>
> Thanks alot for the review and suggestions, I will try to fix them. As for
> v4, I saw there was a "email patch" button in gitlab, so I used that, so
> seems it is not correct :)
>
> BR
>
> On Tue, May 12, 2020 at 11:38 PM Jiri Denemark <jdenemar@redhat.com>
> wrote:
>
>> On Wed, Apr 22, 2020 at 15:11:14 +0800, ZhengZhenyu wrote:
>> > Introduce getHost support for ARM CPU driver. First add
>> > some data about commonly used ARM CPU models, and their
>> > vendors into cpu_map, then added some helper methods as
>> > callbacks to load them. Read and parse vendor_id, part_id
>> > and CPU flags of local CPU from corresponding registers.
>> >
>> > Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@gmail.com>
>>
>> The emails come from ZhengZhenyu <zheng.zhenyu@foxmail.com>, but the
>> signed-off-by line says something else. Could you make them consistent?
>>
>> BTW, I'm intentionally replying to v3 as v4 was only supposed to have a
>> one line diff to v3, but it was sent with both html and plain text parts
>> and git am was unable to apply any of the v4 patches.
>>
>> Jirka
>>
>