Being able to log in as root is critical to recover from failures,
so using bash might not always be the best idea: this is especially
true for FreeBSD, where bash is installed via ports and might break
on update from time to time, rendering the system inaccessible
without jumping through additional hoops.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/update/tasks/users.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/guests/playbooks/update/tasks/users.yml b/guests/playbooks/update/tasks/users.yml
index a07349f..28ee96a 100644
--- a/guests/playbooks/update/tasks/users.yml
+++ b/guests/playbooks/update/tasks/users.yml
@@ -3,7 +3,6 @@
   user:
     name: root
     password: '{{ lookup("file", root_password_file)|password_hash("sha512") }}'
-    shell: '{{ bash }}'
 
 - name: 'root: Configure ssh access'
   authorized_key:
-- 
2.25.3

On Mon, Apr 20, 2020 at 01:13:46PM +0200, Andrea Bolognani wrote:
> Being able to log in as root is critical to recover from failures,
> so using bash might not always be the best idea: this is especially
> true for FreeBSD, where bash is installed via ports and might break
> on update from time to time, rendering the system inaccessible
> without jumping through additional hoops.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/update/tasks/users.yml | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|