From nobody Tue Nov 26 00:22:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587381246; cv=none; d=zohomail.com; s=zohoarc; b=id5z2wAEcyst2cwQITNKF46MGGEKHL5VunaWIYR5ZpwNVtRxmQxiid0G1edeODQU+fe/gCIjv/8pybgUoL2Nkl2hHAnR6Km+McL0noWmeIB3xhIeDkQHaZjIcabRB/u3onwBgs8MCwGntHoNb4RIa2X99ciQSYw4z6atL1z/Tcg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587381246; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=C6GYJdzSe/00VJCbTN96AN555aIEZ1n+t9UL8nOzvfU=; b=YWt2hnz2Z9EoWiH/15AbS4dFj2nwCEiMArujhKlbbMlcrCUN8b9UD+niTN6LvNFUpXQcQYLlIB+QsgqNcPl4sFMStQ1x2OArrvW2xhPEf3GCrEWU4USg2IcB59/dxp6gIlu5IV02m2VQ9IkQm8Zt02BAduoAsEOPTOYukGWE8uo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1587381246670973.1683800372551; Mon, 20 Apr 2020 04:14:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-cZcFieuBO7e6RW5zGEvM_A-1; Mon, 20 Apr 2020 07:14:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 399CC107ACC4; Mon, 20 Apr 2020 11:13:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CB48A1059; Mon, 20 Apr 2020 11:13:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 00E3218095FF; Mon, 20 Apr 2020 11:13:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 03KBDsrg012948 for ; Mon, 20 Apr 2020 07:13:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2930318A85; Mon, 20 Apr 2020 11:13:54 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.195.240]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21BB512972A for ; Mon, 20 Apr 2020 11:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587381245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=C6GYJdzSe/00VJCbTN96AN555aIEZ1n+t9UL8nOzvfU=; b=NivMGS9ZBc031qZRnTStpWqGzIJORTAAdZk77ynp3BtWrdJgN7PnncBILzZLVKdpHYfVFa IYqtEniimub3Wwts4e9pBCtjexXokAWR893w5NGsOVPfbYLP5KL4j7Xu6xiu3SM3jrK9eY yCi2THoB0ngGrbpRW8JTtxiNzK4SAAI= X-MC-Unique: cZcFieuBO7e6RW5zGEvM_A-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt-ci PATCH] lcitool: Don't set root shell Date: Mon, 20 Apr 2020 13:13:46 +0200 Message-Id: <20200420111346.15673-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Being able to log in as root is critical to recover from failures, so using bash might not always be the best idea: this is especially true for FreeBSD, where bash is installed via ports and might break on update from time to time, rendering the system inaccessible without jumping through additional hoops. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/users.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/playbooks/update/tasks/users.yml b/guests/playbooks/upd= ate/tasks/users.yml index a07349f..28ee96a 100644 --- a/guests/playbooks/update/tasks/users.yml +++ b/guests/playbooks/update/tasks/users.yml @@ -3,7 +3,6 @@ user: name: root password: '{{ lookup("file", root_password_file)|password_hash("sha512= ") }}' - shell: '{{ bash }}' =20 - name: 'root: Configure ssh access' authorized_key: --=20 2.25.3