[libvirt PATCH 4/5] docs: QoS parameter 'floor' is supported for 'open' networks too

Pavel Mores posted 5 patches 5 years, 12 months ago
There is a newer version of this series
[libvirt PATCH 4/5] docs: QoS parameter 'floor' is supported for 'open' networks too
Posted by Pavel Mores 5 years, 12 months ago
Relevant code seems to treat forward modes 'route', 'nat', 'open' and none
the same but documentation hasn't reflected that so far.

Signed-off-by: Pavel Mores <pmores@redhat.com>
---
 docs/formatnetwork.html.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 2448fb09e7..3d807ecab6 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.html.in
@@ -631,7 +631,7 @@
           goes through one point where QoS decisions can take place, hence
           why this attribute works only for virtual networks for now
           (that is <code>&lt;interface type='network'/&gt;</code> with a
-          forward type of route, nat, or no forward at all). Moreover, the
+          forward type of route, nat, open or no forward at all). Moreover, the
           virtual network the interface is connected to is required to have
           at least inbound QoS set (<code>average</code> at least). If
           using the <code>floor</code> attribute users don't need to specify
-- 
2.24.1

Re: [libvirt PATCH 4/5] docs: QoS parameter 'floor' is supported for 'open' networks too
Posted by Michal Privoznik 5 years, 12 months ago
On 2/10/20 5:10 PM, Pavel Mores wrote:
> Relevant code seems to treat forward modes 'route', 'nat', 'open' and none

s/none/'none'/

> the same but documentation hasn't reflected that so far.
> 
> Signed-off-by: Pavel Mores <pmores@redhat.com>
> ---
>   docs/formatnetwork.html.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal