[v1] qemu: add stricter checks of permissibility of the QoS parameter 'floor'

[libvirt PATCH 0/5] qemu: add stricter checks of permissibility of the QoS parameter 'floor'

Pavel Mores posted 5 patches 4 years, 2 months ago

Diff against v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200210161041.515468-1-pmores@redhat.com

There is a newer version of this series

docs/formatnetwork.html.in  |  2 +-
src/network/bridge_driver.c | 27 +++++++++++++++++++++------
src/qemu/qemu_driver.c      | 13 ++++++++++---
3 files changed, 32 insertions(+), 10 deletions(-)

Expand all Fold all

[libvirt PATCH 0/5] qemu: add stricter checks of permissibility of the QoS parameter 'floor'

Posted by Pavel Mores 4 years, 2 months ago

Aims to fix

https://bugzilla.redhat.com/show_bug.cgi?id=1750219

Libvirt previously silently accepted attempts to set 'floor' even for
direct bridge interface types where the parameter is not supported.  This
could happen when manipulating both inactive and active (e.g. via 'virsh
domiftune') domain configuration.

Pavel Mores (5):
  qemu: fail on attempt to set 'floor' if interface type is not
    'network'
  qemu: check if 'floor' is supported for given interface and network
  qemu: call networkPlugBandwidth() for all types of network
  docs: QoS parameter 'floor' is supported for 'open' networks too
  qemu: reuse convenience variable introduced in a00b97f27672b3

 docs/formatnetwork.html.in  |  2 +-
 src/network/bridge_driver.c | 27 +++++++++++++++++++++------
 src/qemu/qemu_driver.c      | 13 ++++++++++---
 3 files changed, 32 insertions(+), 10 deletions(-)

-- 
2.24.1

Re: [libvirt PATCH 0/5] qemu: add stricter checks of permissibility of the QoS parameter 'floor'

Posted by Michal Privoznik 4 years, 2 months ago

On 2/10/20 5:10 PM, Pavel Mores wrote:
> Aims to fix
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1750219
> 
> Libvirt previously silently accepted attempts to set 'floor' even for
> direct bridge interface types where the parameter is not supported.  This
> could happen when manipulating both inactive and active (e.g. via 'virsh
> domiftune') domain configuration.
> 
> Pavel Mores (5):
>    qemu: fail on attempt to set 'floor' if interface type is not
>      'network'
>    qemu: check if 'floor' is supported for given interface and network
>    qemu: call networkPlugBandwidth() for all types of network
>    docs: QoS parameter 'floor' is supported for 'open' networks too
>    qemu: reuse convenience variable introduced in a00b97f27672b3
> 
>   docs/formatnetwork.html.in  |  2 +-
>   src/network/bridge_driver.c | 27 +++++++++++++++++++++------
>   src/qemu/qemu_driver.c      | 13 ++++++++++---
>   3 files changed, 32 insertions(+), 10 deletions(-)
> 

Overall, I think these patches put checks at the right places. But I 
think the actual code needs to look a bit different. Looking forward to v2.

Michal