[v1] Import from libvirt.org instead of github.com

[libvirt-go PATCH] Import from libvirt.org instead of github.com

Posted by Andrea Bolognani 4 years, 2 months ago

Since

  commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Mon Dec 16 10:06:50 2019 +0000

    docs: add pages to support Go module package resolution

it's possible to use

  import "libvirt.org/libvirt-go"

in Go programs, which will result in the Go bindings being
fetched directly from libvirt.org thus removing our reliance
on GitHub.

Update the documentation accordingly.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 README.md | 4 ++--
 doc.go    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 326d6a0..c11e9ab 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-# libvirt-go [![Build Status](https://travis-ci.org/libvirt/libvirt-go.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go) [![GoDoc](https://godoc.org/github.com/libvirt/libvirt-go?status.svg)](https://godoc.org/github.com/libvirt/libvirt-go)
+# libvirt-go [![Build Status](https://travis-ci.org/libvirt/libvirt-go.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go) [![GoDoc](https://godoc.org/libvirt.org/libvirt-go?status.svg)](https://godoc.org/libvirt.org/libvirt-go)
 
 Go bindings for libvirt.
 
@@ -32,7 +32,7 @@ changes may apply to future versions:
 
 ## Documentation
 
-* [api documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go)
+* [api documentation for the bindings](https://godoc.org/libvirt.org/t libvirt-go)
 * [api documentation for libvirt](http://libvirt.org/html/libvirt-libvirt.html)
 
 ## Contributing
diff --git a/doc.go b/doc.go
index 55d75b0..35c9962 100644
--- a/doc.go
+++ b/doc.go
@@ -116,7 +116,7 @@
 // To connect to libvirt
 //
 //   import (
-//       libvirt "github.com/libvirt/libvirt-go"
+//       libvirt "libvirt.org/libvirt-go"
 //   )
 //   conn, err := libvirt.NewConnect("qemu:///system")
 //   if err != nil {
-- 
2.24.1

Re: [libvirt-go PATCH] Import from libvirt.org instead of github.com

Posted by Peter Krempa 4 years, 2 months ago

On Thu, Jan 30, 2020 at 13:47:50 +0100, Andrea Bolognani wrote:
> Since
> 
>   commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Mon Dec 16 10:06:50 2019 +0000
> 
>     docs: add pages to support Go module package resolution
> 
> it's possible to use
> 
>   import "libvirt.org/libvirt-go"
> 
> in Go programs, which will result in the Go bindings being
> fetched directly from libvirt.org thus removing our reliance
> on GitHub.
> 
> Update the documentation accordingly.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---

[...]

> @@ -32,7 +32,7 @@ changes may apply to future versions:
>  
>  ## Documentation
>  
> -* [api documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go)
> +* [api documentation for the bindings](https://godoc.org/libvirt.org/t libvirt-go)

This looks broken ^

Re: [libvirt-go PATCH] Import from libvirt.org instead of github.com

Posted by Andrea Bolognani 4 years, 2 months ago

On Thu, 2020-01-30 at 13:58 +0100, Peter Krempa wrote:
> On Thu, Jan 30, 2020 at 13:47:50 +0100, Andrea Bolognani wrote:
> > @@ -32,7 +32,7 @@ changes may apply to future versions:
> >  
> >  ## Documentation
> >  
> > -* [api documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go)
> > +* [api documentation for the bindings](https://godoc.org/libvirt.org/t libvirt-go)
> 
> This looks broken ^

Good catch! I fixed it before pushing :)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt-go PATCH] Import from libvirt.org instead of github.com

Posted by Daniel P. Berrangé 4 years, 2 months ago

On Thu, Jan 30, 2020 at 01:47:50PM +0100, Andrea Bolognani wrote:
> Since
> 
>   commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Mon Dec 16 10:06:50 2019 +0000
> 
>     docs: add pages to support Go module package resolution
> 
> it's possible to use
> 
>   import "libvirt.org/libvirt-go"
> 
> in Go programs, which will result in the Go bindings being
> fetched directly from libvirt.org thus removing our reliance
> on GitHub.
> 
> Update the documentation accordingly.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  README.md | 4 ++--
>  doc.go    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|