[libvirt-go-xml PATCH] Import from libvirt.org instead of github.com

Andrea Bolognani posted 1 patch 4 years, 1 month ago
Failed in applying to current master (apply log)
README.md | 4 ++--
doc.go    | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
[libvirt-go-xml PATCH] Import from libvirt.org instead of github.com
Posted by Andrea Bolognani 4 years, 1 month ago
Since

  commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Mon Dec 16 10:06:50 2019 +0000

    docs: add pages to support Go module package resolution

it's possible to use

  import "libvirt.org/libvirt-go-xml"

in Go programs, which will result in the Go bindings being
fetched directly from libvirt.org thus removing our reliance
on GitHub.

Update the documentation accordingly.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 README.md | 4 ++--
 doc.go    | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 79f42f4..fcc1ffb 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-# libvirt-go-xml [![Build Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go-xml) [![GoDoc](https://godoc.org/github.com/libvirt/libvirt-go-xml?status.svg)](https://godoc.org/github.com/libvirt/libvirt-go-xml)
+# libvirt-go-xml [![Build Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go-xml) [![GoDoc](https://godoc.org/libvirt.org/libvirt-go-xml?status.svg)](https://godoc.org/libvirt.org/libvirt-go-xml)
 
 Go API for manipulating libvirt XML documents
 
@@ -9,7 +9,7 @@ the way in which the application talks to libvirt.
 
 ## Documentation
 
-* [API documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go-xml)
+* [API documentation for the bindings](https://godoc.org/libvirt.org/libvirt-go-xml)
 * [Libvirt XML schema documentation](https://libvirt.org/format.html):
   * [capabilities](https://libvirt.org/formatcaps.html)
   * [domain](https://libvirt.org/formatdomain.html)
diff --git a/doc.go b/doc.go
index 25bc1d5..f93fac0 100644
--- a/doc.go
+++ b/doc.go
@@ -36,7 +36,7 @@
 //  package main
 //
 //  import (
-//   "github.com/libvirt/libvirt-go-xml"
+//   "libvirt.org/libvirt-go-xml"
 //  )
 //
 //  func main() {
@@ -51,8 +51,8 @@
 //  package main
 //
 //  import (
-//    "github.com/libvirt/libvirt-go"
-//    "github.com/libvirt/libvirt-go-xml"
+//    "libvirt.org/libvirt-go"
+//    "libvirt.org/libvirt-go-xml"
 //    "fmt"
 //  )
 //
-- 
2.24.1

Re: [libvirt-go-xml PATCH] Import from libvirt.org instead of github.com
Posted by Daniel P. Berrangé 4 years, 1 month ago
On Thu, Jan 30, 2020 at 01:48:00PM +0100, Andrea Bolognani wrote:
> Since
> 
>   commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Mon Dec 16 10:06:50 2019 +0000
> 
>     docs: add pages to support Go module package resolution
> 
> it's possible to use
> 
>   import "libvirt.org/libvirt-go-xml"
> 
> in Go programs, which will result in the Go bindings being
> fetched directly from libvirt.org thus removing our reliance
> on GitHub.
> 
> Update the documentation accordingly.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  README.md | 4 ++--
>  doc.go    | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|