[libvirt] [PATCH v2 0/5] Support rng backend model builtin

Han Han posted 5 patches 2 weeks ago
Test syntax-check failed
Failed in applying to current master (apply log)
docs/formatdomain.html.in                     | 10 ++++++
docs/formatdomaincaps.html.in                 |  1 +
docs/news.xml                                 | 10 ++++++
docs/schemas/domaincommon.rng                 |  6 ++++
src/conf/domain_audit.c                       |  2 ++
src/conf/domain_conf.c                        |  9 +++++
src/conf/domain_conf.h                        |  1 +
src/qemu/qemu_capabilities.c                  |  4 +++
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_command.c                       | 15 ++++++++
src/qemu/qemu_domain.c                        |  3 ++
src/util/virqemu.c                            | 12 ++++---
.../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |  1 +
.../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |  1 +
.../qemu_4.2.0-virt.aarch64.xml               |  1 +
tests/domaincapsdata/qemu_4.2.0.aarch64.xml   |  1 +
tests/domaincapsdata/qemu_4.2.0.ppc64.xml     |  1 +
tests/domaincapsdata/qemu_4.2.0.s390x.xml     |  1 +
tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |  1 +
.../caps_4.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
.../caps_4.2.0.x86_64.xml                     |  1 +
.../virtio-rng-builtin.x86_64-latest.args     | 35 +++++++++++++++++++
tests/qemuxml2argvdata/virtio-rng-builtin.xml | 26 ++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
.../virtio-rng-builtin.x86_64-latest.xml      | 31 ++++++++++++++++
tests/qemuxml2xmltest.c                       |  1 +
28 files changed, 174 insertions(+), 5 deletions(-)
create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.xml
create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml

[libvirt] [PATCH v2 0/5] Support rng backend model builtin

Posted by Han Han 2 weeks ago
https://bugzilla.redhat.com/show_bug.cgi?id=1785091

Implement 'rng-builtin' backend from QEMU. This feature is introduced
to QEMU since v4.2. It uses getrandom() to get random, no external
random source needed.

github repo: https://github.com/qiankehan/libvirt/tree/rng-builtin_v2
Changes from v1:
- Fix failures in 'make check' and 'make syntax-check'
- Adjust the structure of patches

v1:
https://www.redhat.com/archives/libvir-list/2020-January/msg00000.html

Han Han (5):
  qemu_capabilities: Introduce QEMU_CAPS_OBJECT_RNG_BUILTIN
  util: Do not assume comma after object id
  conf: Add rng backend model builtin
  qemu: Implement builtin rng backend
  news: Update news for rng backend type builtin

 docs/formatdomain.html.in                     | 10 ++++++
 docs/formatdomaincaps.html.in                 |  1 +
 docs/news.xml                                 | 10 ++++++
 docs/schemas/domaincommon.rng                 |  6 ++++
 src/conf/domain_audit.c                       |  2 ++
 src/conf/domain_conf.c                        |  9 +++++
 src/conf/domain_conf.h                        |  1 +
 src/qemu/qemu_capabilities.c                  |  4 +++
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       | 15 ++++++++
 src/qemu/qemu_domain.c                        |  3 ++
 src/util/virqemu.c                            | 12 ++++---
 .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |  1 +
 .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |  1 +
 .../qemu_4.2.0-virt.aarch64.xml               |  1 +
 tests/domaincapsdata/qemu_4.2.0.aarch64.xml   |  1 +
 tests/domaincapsdata/qemu_4.2.0.ppc64.xml     |  1 +
 tests/domaincapsdata/qemu_4.2.0.s390x.xml     |  1 +
 tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |  1 +
 .../caps_4.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
 .../caps_4.2.0.x86_64.xml                     |  1 +
 .../virtio-rng-builtin.x86_64-latest.args     | 35 +++++++++++++++++++
 tests/qemuxml2argvdata/virtio-rng-builtin.xml | 26 ++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 .../virtio-rng-builtin.x86_64-latest.xml      | 31 ++++++++++++++++
 tests/qemuxml2xmltest.c                       |  1 +
 28 files changed, 174 insertions(+), 5 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.xml
 create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml

-- 
2.24.0.rc1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [PATCH v2 0/5] Support rng backend model builtin

Posted by Michal Privoznik 20 hours ago
On 1/9/20 9:00 AM, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1785091
> 
> Implement 'rng-builtin' backend from QEMU. This feature is introduced
> to QEMU since v4.2. It uses getrandom() to get random, no external
> random source needed.
> 
> github repo: https://github.com/qiankehan/libvirt/tree/rng-builtin_v2
> Changes from v1:
> - Fix failures in 'make check' and 'make syntax-check'
> - Adjust the structure of patches
> 
> v1:
> https://www.redhat.com/archives/libvir-list/2020-January/msg00000.html
> 
> Han Han (5):
>    qemu_capabilities: Introduce QEMU_CAPS_OBJECT_RNG_BUILTIN
>    util: Do not assume comma after object id
>    conf: Add rng backend model builtin
>    qemu: Implement builtin rng backend
>    news: Update news for rng backend type builtin
> 
>   docs/formatdomain.html.in                     | 10 ++++++
>   docs/formatdomaincaps.html.in                 |  1 +
>   docs/news.xml                                 | 10 ++++++
>   docs/schemas/domaincommon.rng                 |  6 ++++
>   src/conf/domain_audit.c                       |  2 ++
>   src/conf/domain_conf.c                        |  9 +++++
>   src/conf/domain_conf.h                        |  1 +
>   src/qemu/qemu_capabilities.c                  |  4 +++
>   src/qemu/qemu_capabilities.h                  |  1 +
>   src/qemu/qemu_command.c                       | 15 ++++++++
>   src/qemu/qemu_domain.c                        |  3 ++
>   src/util/virqemu.c                            | 12 ++++---
>   .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |  1 +
>   .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |  1 +
>   .../qemu_4.2.0-virt.aarch64.xml               |  1 +
>   tests/domaincapsdata/qemu_4.2.0.aarch64.xml   |  1 +
>   tests/domaincapsdata/qemu_4.2.0.ppc64.xml     |  1 +
>   tests/domaincapsdata/qemu_4.2.0.s390x.xml     |  1 +
>   tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |  1 +
>   .../caps_4.2.0.aarch64.xml                    |  1 +
>   .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
>   .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
>   .../caps_4.2.0.x86_64.xml                     |  1 +
>   .../virtio-rng-builtin.x86_64-latest.args     | 35 +++++++++++++++++++
>   tests/qemuxml2argvdata/virtio-rng-builtin.xml | 26 ++++++++++++++
>   tests/qemuxml2argvtest.c                      |  1 +
>   .../virtio-rng-builtin.x86_64-latest.xml      | 31 ++++++++++++++++
>   tests/qemuxml2xmltest.c                       |  1 +
>   28 files changed, 174 insertions(+), 5 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.xml
>   create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml
> 

Sorry for delayed response. I've rebased onto current master and pushed.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal