From nobody Sat Apr 20 12:26:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
205.139.110.61 as permitted sender) client-ip=205.139.110.61;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1578556968; cv=none;
d=zohomail.com; s=zohoarc;
b=VRLCqWs/DO9+55Xt0lI6qXKvF/I8YvE7fqtkdvqYhWfjKTan+tBj4sFYtxoj9xuCQSZGLD6IiiBm5VzMaooD4g5Wxesd/mUGemfPOye8brsBF/Of+jD2dnCaYMVW9o90baOpBPM0vwIc5xK0e4witeht9FdNR0KC8CJTT0UC+qA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1578556968;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=WdNq0uY8/7fOrFlnctdPzD8KDcIIVHiu8ZwHdcCxJhY=;
b=PuD5WLgeGzg1gBPystys7EKfxHMvA/vEQWrWeaip4b1dgD9AC3C3ZXNEUejzoyjAoUzhl8vHCwyDBgDcLarwNNEWbbw13iZdRuC4nDX+z7C6ySelIZjuyGe7JRAcqeDu47lOy9gifLX3n5dx8yxGURbfg8tajAUnMwu+vaVnZO4=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61]) by mx.zohomail.com
with SMTPS id 1578556968602579.9888607938879;
Thu, 9 Jan 2020 00:02:48 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-272-IQA2eRYFMF2IiAz7j8dsgw-1; Thu, 09 Jan 2020 03:02:45 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
[10.5.11.12])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 135168C60F4;
Thu, 9 Jan 2020 08:02:39 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 1572860CC0;
Thu, 9 Jan 2020 08:02:38 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7EE161809567;
Thu, 9 Jan 2020 08:02:35 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 00982Xlj012868 for ;
Thu, 9 Jan 2020 03:02:33 -0500
Received: by smtp.corp.redhat.com (Postfix)
id 39E851001B2C; Thu, 9 Jan 2020 08:02:33 +0000 (UTC)
Received: from hansolo.redhat.com (ovpn-12-147.pek2.redhat.com [10.72.12.147])
by smtp.corp.redhat.com (Postfix) with ESMTP id A421C1000322;
Thu, 9 Jan 2020 08:02:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1578556967;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=WdNq0uY8/7fOrFlnctdPzD8KDcIIVHiu8ZwHdcCxJhY=;
b=SXGkXLFGw4Zq6OMGUNV0E3PdOgLwFxQjQ3fCJzlWjVx1FyI01/Lgg7JAmg0hUGAgcpFvCA
L2RFQL67eVIX9EnZ+14sHSD2v1QBUlYCw1SeZyFsPjCBFEJqSvVccKIftbY1MADTdWrwvu
YAlHT67BWWGxjw2zAxISlilKrsJ1d5g=
From: Han Han
To: libvir-list@redhat.com
Date: Thu, 9 Jan 2020 16:00:05 +0800
Message-Id: <20200109080009.20281-2-hhan@redhat.com>
In-Reply-To: <20200109080009.20281-1-hhan@redhat.com>
References: <20200109080009.20281-1-hhan@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: mprivozn@redhat.com, pkrempa@redhat.com, Han Han
Subject: [libvirt] [PATCH v2 1/5] qemu_capabilities: Introduce
QEMU_CAPS_OBJECT_RNG_BUILTIN
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-MC-Unique: IQA2eRYFMF2IiAz7j8dsgw-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
It is used to check if qemu is capable of rng-builtin object.
This object is added since qemu-4.2.0-rc0, commit 6c4e9d48.
Signed-off-by: Han Han
Reviewed-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 +
6 files changed, 7 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index da0c7a257f..8d7b9e368a 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -553,6 +553,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
"blockdev-file-dynamic-auto-read-only",
"savevm-monitor-nodes",
"drive-nvme",
+ "rng-builtin",
);
=20
=20
@@ -1244,6 +1245,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[=
] =3D {
{ "vhost-user-vga", QEMU_CAPS_DEVICE_VHOST_USER_VGA },
{ "ramfb", QEMU_CAPS_DEVICE_RAMFB },
{ "max-arm-cpu", QEMU_CAPS_ARM_MAX_CPU },
+ { "rng-builtin", QEMU_CAPS_OBJECT_RNG_BUILTIN },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBalloon[]=
=3D {
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 193c19fc81..f25b60a2b3 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -534,6 +534,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for =
syntax-check */
QEMU_CAPS_BLOCK_FILE_AUTO_READONLY_DYNAMIC, /* the auto-read-only prop=
erty of block backends for files is dynamic */
QEMU_CAPS_SAVEVM_MONITOR_NODES, /* 'savevm' handles monitor-owned node=
s properly */
QEMU_CAPS_DRIVE_NVME, /* -drive file.driver=3Dnvme */
+ QEMU_CAPS_OBJECT_RNG_BUILTIN, /* -object rng-builtin */
=20
QEMU_CAPS_LAST /* this must always be the last item */
} virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml b/tests/qemu=
capabilitiesdata/caps_4.2.0.aarch64.xml
index a6469073fd..b436367068 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
@@ -175,6 +175,7 @@
+
4001050
0
61700242
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml b/tests/qemuca=
pabilitiesdata/caps_4.2.0.ppc64.xml
index ee9fb23640..9b22e3feb2 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
@@ -176,6 +176,7 @@
+
4001050
0
42900242
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml b/tests/qemuca=
pabilitiesdata/caps_4.2.0.s390x.xml
index fdf5cb4ce9..4c13f67262 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
@@ -135,6 +135,7 @@
+
4001050
0
39100242
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemuc=
apabilitiesdata/caps_4.2.0.x86_64.xml
index 4857e2f5a5..93de5c37e8 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
@@ -218,6 +218,7 @@
+
4002000
0
43100242
--=20
2.24.0.rc1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Sat Apr 20 12:26:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.81 as permitted sender) client-ip=207.211.31.81;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1578556969; cv=none;
d=zohomail.com; s=zohoarc;
b=J6ofTJ/6ecSZ+rVyU3t+3J/930AZct4vTXE7UGalvcW1AiPP1lZwid3Vguk/hZtBRNr9duBcfUt9izkkZ32ZbFhTbApv815P86zdlDuznorLKn0RzEdU/x7iIdNvNhj3uQ83xUUxladbXoT72zShGDa8LnWi3YBYbWVtBGxjU9U=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1578556969;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=SIi+8MtwcyCRjROM/kDX1YYC0+UZ5gxPPPV8okrDSHk=;
b=C+9bXRAAE0TpxbCa8vqbtoZRYgiKVm8LZFeZi1A1B+gyOHKxfS7qUeRNrGrNguYRj1qp8xF0R33TS9sfPw35TrkFkjh8/VSCeZxrSs+56tnr8GYQJ0KflscVtX2/Dkx9UK64DJv+pPVrXRmrlDbG/1+fnhX9HDDCxCLN/EKzvoc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
[207.211.31.81]) by mx.zohomail.com
with SMTPS id 1578556969383752.5283619922606;
Thu, 9 Jan 2020 00:02:49 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-417-miToro-YMB6evxpo7Cttfg-1; Thu, 09 Jan 2020 03:02:46 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
[10.5.11.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5664101FCDA;
Thu, 9 Jan 2020 08:02:40 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 7DF3F5C241;
Thu, 9 Jan 2020 08:02:40 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id D777518089CD;
Thu, 9 Jan 2020 08:02:39 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 00982c50012879 for ;
Thu, 9 Jan 2020 03:02:38 -0500
Received: by smtp.corp.redhat.com (Postfix)
id 250E31001B2C; Thu, 9 Jan 2020 08:02:38 +0000 (UTC)
Received: from hansolo.redhat.com (ovpn-12-147.pek2.redhat.com [10.72.12.147])
by smtp.corp.redhat.com (Postfix) with ESMTP id 0CA8A1000328;
Thu, 9 Jan 2020 08:02:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1578556968;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=SIi+8MtwcyCRjROM/kDX1YYC0+UZ5gxPPPV8okrDSHk=;
b=FgsfAtT43kTiwkaXxf9tqnU1mP9wcgDPaLp8mHxjervwmxBT3/Rxp30KboV/wVHiPKIIGH
IFM+ijUGVU7OPpM0edN1dxFrCi+K+4N6hK3+GEIucucWiQc0b4kri32o9GJ9DnbxLAUomo
atwFAoEFQ7jpmETI9EEFq1x/u6aSvhM=
From: Han Han
To: libvir-list@redhat.com
Date: Thu, 9 Jan 2020 16:00:06 +0800
Message-Id: <20200109080009.20281-3-hhan@redhat.com>
In-Reply-To: <20200109080009.20281-1-hhan@redhat.com>
References: <20200109080009.20281-1-hhan@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: mprivozn@redhat.com, pkrempa@redhat.com, Han Han
Subject: [libvirt] [PATCH v2 2/5] util: Do not assume comma after object id
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: miToro-YMB6evxpo7Cttfg-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
For qemu object like rng-builtin, there are no properties after id
property. We should always set comma after object id. Otherwise it will
cause trailing comma on object:
-object rng-builtin,id=3DID,
Signed-off-by: Han Han
Reviewed-by: Michal Privoznik
---
src/util/virqemu.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index f3a233af3d..8d0429625d 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@ -239,12 +239,14 @@ virQEMUBuildObjectCommandlineFromJSONInternal(virBuff=
erPtr buf,
return -1;
}
=20
- virBufferAsprintf(buf, "%s,id=3D%s,", type, alias);
+ virBufferAsprintf(buf, "%s,id=3D%s", type, alias);
=20
- if (props &&
- virQEMUBuildCommandLineJSON(props, buf,
- virQEMUBuildCommandLineJSONArrayBitmap=
) < 0)
- return -1;
+ if (props) {
+ virBufferAddLit(buf, ",");
+ if (virQEMUBuildCommandLineJSON(props, buf,
+ virQEMUBuildCommandLineJSONArrayBitmap) < =
0)
+ return -1;
+ }
=20
return 0;
}
--=20
2.24.0.rc1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Sat Apr 20 12:26:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.120 as permitted sender) client-ip=207.211.31.120;
envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1578556988; cv=none;
d=zohomail.com; s=zohoarc;
b=R29eTv66ulJZ5XYbMlWYSm7ZKPDPbgxE9O2hsk7lRlrADOgU9vJNXD6vQXnyxTiZWMAt2nZV0GjrM+Jk/w5YW+DBupOs0V8RdcpzXCkQwTwlxPKoIxnOrMuQS+r5YuWgHxvJT4t9bnsAvrrqGKE8omR8Ac6Aih89Pewn70+VNdQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1578556988;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=2czrs9xoGHK7kecrC7vTfSGBp5x5bWBSMiPwh+z3g+E=;
b=RfriihGB2chXJzDYIB5Befp9uTaEQi0lf+B1Mo7VwmgLnhkYGwLliPzhOoiznlEl2oUcOYKofe1YrX9qqYxQKs3cZZb5lLQQsjC4OmhS7enCEM0ZgXPcizk08xoXf0CrCzzZOGs2LnefPC9mGWKese52GdehzRoFYDVYae15r9Y=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by mx.zohomail.com
with SMTPS id 1578556988548733.6769064626628;
Thu, 9 Jan 2020 00:03:08 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-379-39LGX7DtOHerEEC05IQwmA-1; Thu, 09 Jan 2020 03:03:02 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1C898005B4;
Thu, 9 Jan 2020 08:02:56 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 884D25DA2C;
Thu, 9 Jan 2020 08:02:56 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3F87E503BA;
Thu, 9 Jan 2020 08:02:56 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 00982ip7012895 for ;
Thu, 9 Jan 2020 03:02:44 -0500
Received: by smtp.corp.redhat.com (Postfix)
id 2E8A71000322; Thu, 9 Jan 2020 08:02:44 +0000 (UTC)
Received: from hansolo.redhat.com (ovpn-12-147.pek2.redhat.com [10.72.12.147])
by smtp.corp.redhat.com (Postfix) with ESMTP id F12461000328;
Thu, 9 Jan 2020 08:02:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1578556987;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=2czrs9xoGHK7kecrC7vTfSGBp5x5bWBSMiPwh+z3g+E=;
b=f3/95ay2lLSATIJjmHicNTQtptSr0UzBr9OrOtutM9nQGmoA5tzRpAjA4CWdyejaprzwa2
mNbP+5ljJXG9M9EqHVvn+fT93AwIduGXDZnT3Xv1m4kiRQ8GyVvq3oTa/U5IIlFrSGRW2u
fP/+A60u3JlaOsG6zfle+uC8/nZK2z4=
From: Han Han
To: libvir-list@redhat.com
Date: Thu, 9 Jan 2020 16:00:07 +0800
Message-Id: <20200109080009.20281-4-hhan@redhat.com>
In-Reply-To: <20200109080009.20281-1-hhan@redhat.com>
References: <20200109080009.20281-1-hhan@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: mprivozn@redhat.com, pkrempa@redhat.com, Han Han
Subject: [libvirt] [PATCH v2 3/5] conf: Add rng backend model builtin
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-MC-Unique: 39LGX7DtOHerEEC05IQwmA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
The 'builtin' rng backend model can be used as following:
Signed-off-by: Han Han
Reviewed-by: Michal Privoznik
---
docs/formatdomain.html.in | 10 ++++++++++
docs/formatdomaincaps.html.in | 1 +
docs/schemas/domaincommon.rng | 6 ++++++
src/conf/domain_audit.c | 2 ++
src/conf/domain_conf.c | 9 +++++++++
src/conf/domain_conf.h | 1 +
6 files changed, 29 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 3040448df1..9621b5f120 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -8257,6 +8257,8 @@ qemu-kvm -net nic,model=3D? /dev/null
<source mode=3D'bind' service=3D'1234'/>
<source mode=3D'connect' host=3D'1.2.3.4' service=3D'1234'/>
</backend>
+ <!-- OR -->
+ <backend model=3D'builtin'/>
</rng>
</devices>
...
@@ -8321,6 +8323,14 @@ qemu-kvm -net nic,model=3D? /dev/null
for more information.
+ builtin
+
+
+ This backend uses qemu builtin random generator, which uses
+ getrandom() syscall to generate random.
+ (Since 6.0.0 and QEMU 4.2)
+
+
driver
diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index 6bf7a1c17a..aa4dece220 100644
--- a/docs/formatdomaincaps.html.in
+++ b/docs/formatdomaincaps.html.in
@@ -481,6 +481,7 @@
<enum name=3D'backendModel'>
<value>random</value>
<value>egd</value>
+ <value>builtin</value>
</enum>
</rng>
...
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 9b555d6acb..bbcf6ce896 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -5681,6 +5681,12 @@
[
][
+
+
+ builtin
+
+
+
diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
index fdccc585fb..138f270129 100644
--- a/src/conf/domain_audit.c
+++ b/src/conf/domain_audit.c
@@ -227,6 +227,7 @@ virDomainAuditRNG(virDomainObjPtr vm,
newsrcpath =3D virDomainChrSourceDefGetPath(newDef->source.cha=
rdev);
break;
=20
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
@@ -242,6 +243,7 @@ virDomainAuditRNG(virDomainObjPtr vm,
oldsrcpath =3D virDomainChrSourceDefGetPath(oldDef->source.cha=
rdev);
break;
=20
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6b05d06481..dc0c8997bc 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1112,6 +1112,7 @@ VIR_ENUM_IMPL(virDomainRNGBackend,
VIR_DOMAIN_RNG_BACKEND_LAST,
"random",
"egd",
+ "builtin",
);
=20
VIR_ENUM_IMPL(virDomainTPMModel,
@@ -14783,6 +14784,7 @@ virDomainRNGDefParseXML(virDomainXMLOptionPtr xmlop=
t,
goto error;
break;
=20
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
@@ -17709,6 +17711,7 @@ virDomainRNGFind(virDomainDefPtr def,
continue;
break;
=20
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
@@ -26386,6 +26389,11 @@ virDomainRNGDefFormat(virBufferPtr buf,
return -1;
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "\n");
+ break;
+
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
+ virBufferAddLit(buf, "/>\n");
+ break;
=20
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
@@ -26417,6 +26425,7 @@ virDomainRNGDefFree(virDomainRNGDefPtr def)
case VIR_DOMAIN_RNG_BACKEND_EGD:
virObjectUnref(def->source.chardev);
break;
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index e6b06a8eba..17d7ad9229 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2103,6 +2103,7 @@ typedef enum {
typedef enum {
VIR_DOMAIN_RNG_BACKEND_RANDOM,
VIR_DOMAIN_RNG_BACKEND_EGD,
+ VIR_DOMAIN_RNG_BACKEND_BUILTIN,
=20
VIR_DOMAIN_RNG_BACKEND_LAST
} virDomainRNGBackend;
--=20
2.24.0.rc1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Sat Apr 20 12:26:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.81 as permitted sender) client-ip=207.211.31.81;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1578556985; cv=none;
d=zohomail.com; s=zohoarc;
b=k1a9g/bLJ+DKu3L+/u8fP3rl8ZCNdvM4HRmUwdAOE5no5MrCp4zRZsZtbUZb8m6ttJVD3ZNXUpP2yXjLriX95t3hcynJFdBtiWhQygwZjw8pAJxdcUyuU8JyOqyUoJAMc6ANbLgiFSxjS0u6fDwtY2YARBnHjBYFv6l6GuPHw0M=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1578556985;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=4iRyeZc9GoNE0e48cacSqKE9pNfMh19/NRcWmhUBvSs=;
b=dK/KUBsJgLZKlmzaqwCvFz8ejjb6fQCAEkNFHguhkBTFIXXAkGLKCJos2G3Tb9uxEfgAo7VWklp3m4Vk5RMgLTlG+9cqYGJQ0CrvpIoJ4g28uobe1CblDAzAtjWd1TgM3wSha13JbB7YEV2yOwCPQXD/j4h6Ua9UdQXoOfZsr68=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
[207.211.31.81]) by mx.zohomail.com
with SMTPS id 1578556985743813.1760986065406;
Thu, 9 Jan 2020 00:03:05 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-379-LP9CFWxhNYS7pxrCQ86ojA-1; Thu, 09 Jan 2020 03:03:02 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44A6718A8C8A;
Thu, 9 Jan 2020 08:02:56 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DB1784665;
Thu, 9 Jan 2020 08:02:56 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id CB8C518089C8;
Thu, 9 Jan 2020 08:02:55 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 00982kvA012906 for ;
Thu, 9 Jan 2020 03:02:46 -0500
Received: by smtp.corp.redhat.com (Postfix)
id 85FBD1001925; Thu, 9 Jan 2020 08:02:46 +0000 (UTC)
Received: from hansolo.redhat.com (ovpn-12-147.pek2.redhat.com [10.72.12.147])
by smtp.corp.redhat.com (Postfix) with ESMTP id C9C1F1000322;
Thu, 9 Jan 2020 08:02:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1578556983;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=4iRyeZc9GoNE0e48cacSqKE9pNfMh19/NRcWmhUBvSs=;
b=bG1c0lTvHpd7BjirpEmSwJyVixh6Et4wPkMmRE21wMDbccF5r35aRS1LyjQsv/tV9OXH9J
ZR8opQ0VGtr8UqyzebpMPnaRjwtmfn+YN0zoH42BpAQzzeg12CJs0XYq3Q+B/AJcE1qFGK
aZNN40R6ev+6nPstLboC8ARlr0rtSEE=
From: Han Han
To: libvir-list@redhat.com
Date: Thu, 9 Jan 2020 16:00:08 +0800
Message-Id: <20200109080009.20281-5-hhan@redhat.com>
In-Reply-To: <20200109080009.20281-1-hhan@redhat.com>
References: <20200109080009.20281-1-hhan@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: mprivozn@redhat.com, pkrempa@redhat.com, Han Han
Subject: [libvirt] [PATCH v2 4/5] qemu: Implement builtin rng backend
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: LP9CFWxhNYS7pxrCQ86ojA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Since v4.2-rc0, QEMU introduced a builtin rng backend that uses
getrandom() syscall to generate random. Add it to libvirt with the
backend model 'builtin'.
https://bugzilla.redhat.com/show_bug.cgi?id=3D1785091
Signed-off-by: Han Han
Reviewed-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_command.c | 15 ++++++++
src/qemu/qemu_domain.c | 3 ++
.../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 +
.../qemu_4.2.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 +
.../virtio-rng-builtin.x86_64-latest.args | 35 +++++++++++++++++++
tests/qemuxml2argvdata/virtio-rng-builtin.xml | 26 ++++++++++++++
tests/qemuxml2argvtest.c | 1 +
.../virtio-rng-builtin.x86_64-latest.xml | 31 ++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
15 files changed, 121 insertions(+)
create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest=
.args
create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.xml
create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-late=
st.xml
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 8d7b9e368a..fe2122f320 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -5716,6 +5716,8 @@ virQEMUCapsFillDomainDeviceRNGCaps(virQEMUCapsPtr qem=
uCaps,
VIR_DOMAIN_CAPS_ENUM_SET(rng->backendModel, VIR_DOMAIN_RNG_BACKEND=
_EGD);
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_RNG_RANDOM))
VIR_DOMAIN_CAPS_ENUM_SET(rng->backendModel, VIR_DOMAIN_RNG_BACKEND=
_RANDOM);
+ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_RNG_BUILTIN))
+ VIR_DOMAIN_CAPS_ENUM_SET(rng->backendModel, VIR_DOMAIN_RNG_BACKEND=
_BUILTIN);
}
=20
=20
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index d0b1f34058..84529af596 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -5569,6 +5569,7 @@ qemuBuildRNGBackendChrdevStr(virLogManagerPtr logMana=
ger,
=20
switch ((virDomainRNGBackend) rng->backend) {
case VIR_DOMAIN_RNG_BACKEND_RANDOM:
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
/* no chardev backend is needed */
return 0;
@@ -5630,6 +5631,20 @@ qemuBuildRNGBackendProps(virDomainRNGDefPtr rng,
=20
break;
=20
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
+ if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_RNG_BUILTIN)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("this qemu doesn't support the rng-builtin "
+ "backend"));
+ return -1;
+ }
+
+ if (qemuMonitorCreateObjectProps(props, "rng-builtin", objAlias,
+ NULL) < 0)
+ return -1;
+
+ break;
+
case VIR_DOMAIN_RNG_BACKEND_LAST:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("unknown rng-random backend"));
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2ec23bb52f..a5ca73e41f 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -14794,6 +14794,7 @@ qemuDomainSetupRNG(virQEMUDriverConfigPtr cfg G_GNU=
C_UNUSED,
return -1;
=20
case VIR_DOMAIN_RNG_BACKEND_EGD:
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
/* nada */
break;
@@ -15773,6 +15774,7 @@ qemuDomainNamespaceSetupRNG(virDomainObjPtr vm,
break;
=20
case VIR_DOMAIN_RNG_BACKEND_EGD:
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
@@ -15796,6 +15798,7 @@ qemuDomainNamespaceTeardownRNG(virDomainObjPtr vm,
break;
=20
case VIR_DOMAIN_RNG_BACKEND_EGD:
+ case VIR_DOMAIN_RNG_BACKEND_BUILTIN:
case VIR_DOMAIN_RNG_BACKEND_LAST:
break;
}
diff --git a/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml b/tests/domainc=
apsdata/qemu_4.2.0-q35.x86_64.xml
index c4c6bfb564..eaa3b75695 100644
--- a/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml
@@ -167,6 +167,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml b/tests/domainc=
apsdata/qemu_4.2.0-tcg.x86_64.xml
index a7f8d9c5ee..af482e3821 100644
--- a/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml
@@ -178,6 +178,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml b/tests/domai=
ncapsdata/qemu_4.2.0-virt.aarch64.xml
index e5954717cc..908406bf11 100644
--- a/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml
@@ -136,6 +136,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0.aarch64.xml b/tests/domaincaps=
data/qemu_4.2.0.aarch64.xml
index bb02b1d850..c66550cec5 100644
--- a/tests/domaincapsdata/qemu_4.2.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.aarch64.xml
@@ -134,6 +134,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0.ppc64.xml b/tests/domaincapsda=
ta/qemu_4.2.0.ppc64.xml
index 6d3ada3735..7906482eee 100644
--- a/tests/domaincapsdata/qemu_4.2.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.ppc64.xml
@@ -100,6 +100,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0.s390x.xml b/tests/domaincapsda=
ta/qemu_4.2.0.s390x.xml
index c6d92542c3..0cdfd4352e 100644
--- a/tests/domaincapsdata/qemu_4.2.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.s390x.xml
@@ -191,6 +191,7 @@
random
egd
+ builtin
diff --git a/tests/domaincapsdata/qemu_4.2.0.x86_64.xml b/tests/domaincapsd=
ata/qemu_4.2.0.x86_64.xml
index f0e0f182a4..c82d12d3ce 100644
--- a/tests/domaincapsdata/qemu_4.2.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.x86_64.xml
@@ -167,6 +167,7 @@
random
egd
+ builtin
diff --git a/tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args b=
/tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args
new file mode 100644
index 0000000000..e55117728c
--- /dev/null
+++ b/tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-latest.args
@@ -0,0 +1,35 @@
+LC_ALL=3DC \
+PATH=3D/bin \
+HOME=3D/tmp/lib/domain--1-QEMUGuest1 \
+USER=3Dtest \
+LOGNAME=3Dtest \
+XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.local/share \
+XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.cache \
+XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \
+QEMU_AUDIO_DRV=3Dnone \
+/usr/bin/qemu-system-x86_64 \
+-name guest=3DQEMUGuest1,debug-threads=3Don \
+-S \
+-object secret,id=3DmasterKey0,format=3Draw,\
+file=3D/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
+-machine pc,accel=3Dkvm,usb=3Doff,dump-guest-core=3Doff \
+-m 214 \
+-overcommit mem-lock=3Doff \
+-smp 1,sockets=3D1,cores=3D1,threads=3D1 \
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=3Dcharmonitor,fd=3D1729,server,nowait \
+-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \
+-rtc base=3Dutc \
+-no-shutdown \
+-no-acpi \
+-boot strict=3Don \
+-device piix3-usb-uhci,id=3Dusb,bus=3Dpci.0,addr=3D0x1.0x2 \
+-device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0x2 \
+-object rng-builtin,id=3Dobjrng0 \
+-device virtio-rng-pci,rng=3Dobjrng0,id=3Drng0,bus=3Dpci.0,addr=3D0x3 \
+-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,\
+resourcecontrol=3Ddeny \
+-msg timestamp=3Don
diff --git a/tests/qemuxml2argvdata/virtio-rng-builtin.xml b/tests/qemuxml2=
argvdata/virtio-rng-builtin.xml
new file mode 100644
index 0000000000..0a03eafc4b
--- /dev/null
+++ b/tests/qemuxml2argvdata/virtio-rng-builtin.xml
@@ -0,0 +1,26 @@
+
+ QEMUGuest1
+ c7a5fdbd-edaf-9455-926a-d65c16db1809
+ 219100
+ 219100
+ 1
+
+ hvm
+
+
+
+ destroy
+ restart
+ destroy
+
+ /usr/bin/qemu-system-x86_64
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 8af2ba38d3..44c86a8938 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2119,6 +2119,7 @@ mymain(void)
DO_TEST("virtio-rng-egd",
QEMU_CAPS_DEVICE_VIRTIO_RNG,
QEMU_CAPS_OBJECT_RNG_EGD);
+ DO_TEST_CAPS_LATEST("virtio-rng-builtin");
DO_TEST_CAPS_VER("virtio-rng-egd-unix", "2.5.0");
DO_TEST_CAPS_LATEST("virtio-rng-egd-unix");
DO_TEST("virtio-rng-multiple",
diff --git a/tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml =
b/tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml
new file mode 100644
index 0000000000..9ff57c4ad6
--- /dev/null
+++ b/tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-latest.xml
@@ -0,0 +1,31 @@
+
+ QEMUGuest1
+ c7a5fdbd-edaf-9455-926a-d65c16db1809
+ 219100
+ 219100
+ 1
+
+ hvm
+
+
+
+ destroy
+ restart
+ destroy
+
+ /usr/bin/qemu-system-x86_64
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 262fc835f5..faa9c097fb 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -629,6 +629,7 @@ mymain(void)
QEMU_CAPS_DEVICE_VIRTIO_RNG);
DO_TEST("virtio-rng-egd",
QEMU_CAPS_DEVICE_VIRTIO_RNG);
+ DO_TEST_CAPS_LATEST("virtio-rng-builtin");
=20
DO_TEST("pseries-nvram",
QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE,
--=20
2.24.0.rc1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Sat Apr 20 12:26:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
205.139.110.61 as permitted sender) client-ip=205.139.110.61;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1578556990; cv=none;
d=zohomail.com; s=zohoarc;
b=fqn8vawYsRdC1kHj9d3JKAM5h3V5QcixIvX79QlldIg6YlZO0BAZqtxcNWUFFm63FjDj6SXwaR8HL1GpsieWQQOmaA5lIkqWYRd5lfXkZ6ptA1Mk4BCOQeMJ23MXpadHmNdeScjkBWAMiO0YUYAog1QwLLRYZkDipGmdpNsE2yQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1578556990;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=ewW5hc0XK9fdHcFf5ofLQEdfhEX/BmdkR6UGOMjKmVQ=;
b=dYU2y88AW1lMnryfEzL2uPDcN1D3KaBnfB4GExWkNmHInw5qoipslAGehhptb+mLOPAXxe80WFYSv+5rpZAutUJpoOpv7ZmbyCIBlcm3wIvu5eMawRP7EZIV1zl/d5wTP9/NyCxeCyzHZw6TwLb/knnU3XFClmb9MmQvbImjUqc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=pass header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
[205.139.110.61]) by mx.zohomail.com
with SMTPS id 1578556990111223.25264688990796;
Thu, 9 Jan 2020 00:03:10 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-34-dKp7Sx3bPKe5BZnXmvhJXA-1; Thu, 09 Jan 2020 03:03:06 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF9ED8005B8;
Thu, 9 Jan 2020 08:03:00 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id A618B272CC;
Thu, 9 Jan 2020 08:03:00 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5569D18089CF;
Thu, 9 Jan 2020 08:03:00 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 00982r0C012924 for ;
Thu, 9 Jan 2020 03:02:54 -0500
Received: by smtp.corp.redhat.com (Postfix)
id ED73B1001B2C; Thu, 9 Jan 2020 08:02:53 +0000 (UTC)
Received: from hansolo.redhat.com (ovpn-12-147.pek2.redhat.com [10.72.12.147])
by smtp.corp.redhat.com (Postfix) with ESMTP id 283201000322;
Thu, 9 Jan 2020 08:02:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1578556988;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=ewW5hc0XK9fdHcFf5ofLQEdfhEX/BmdkR6UGOMjKmVQ=;
b=Y+mjdX0r5G95RdcfwVAb2oiezHB8U/4PGB36mMJq5MOSC8BkhttuRHNdp4GvHwt9pHPX44
bHpALm2CWh7j0TEssZO2DjuUYGYEnjfQafKFvFrxT5XtcB6n3HGPArRValV2t8xRSk236z
cozuTLd67k6i5EvaF0gZmxtKHdONHXc=
From: Han Han
To: libvir-list@redhat.com
Date: Thu, 9 Jan 2020 16:00:09 +0800
Message-Id: <20200109080009.20281-6-hhan@redhat.com>
In-Reply-To: <20200109080009.20281-1-hhan@redhat.com>
References: <20200109080009.20281-1-hhan@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: mprivozn@redhat.com, pkrempa@redhat.com, Han Han
Subject: [libvirt] [PATCH v2 5/5] news: Update news for rng backend type
builtin
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-MC-Unique: dKp7Sx3bPKe5BZnXmvhJXA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Signed-off-by: Han Han
Reviewed-by: Michal Privoznik
---
docs/news.xml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 1af57f8af0..d10a8b7936 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,16 @@
guest.
+
+
+ qemu: new rng backend type: builtin
+
+
+ It implements qemu builtin rng backend. That uses getrandom sysc=
all
+ to generate random, no external rng source needed. Available sin=
ce
+ QEMU 4.2.
+
+
--=20
2.24.0.rc1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
]