[libvirt] [PATCH v2 2/3] docs: Reformat snapshot-revert force reasons

Michael Weiser posted 3 patches 6 years, 1 month ago
There is a newer version of this series
[libvirt] [PATCH v2 2/3] docs: Reformat snapshot-revert force reasons
Posted by Michael Weiser 6 years, 1 month ago
Reformat explanations of the snapshot-revert force reasons in
preparation for more to be added. This is a simple reformat without any
wording changes.

Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
Cc: Cole Robinson <crobinso@redhat.com>
---
 docs/manpages/virsh.rst | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index fea0527caf..f5f962cba1 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -6952,20 +6952,22 @@ transient domains cannot be inactive, it is required to use one of these
 flags when reverting to a disk snapshot of a transient domain.
 
 There are two cases where a snapshot revert involves extra risk, which
-requires the use of *--force* to proceed.  One is the case of a
-snapshot that lacks full domain information for reverting
-configuration (such as snapshots created prior to libvirt 0.9.5);
-since libvirt cannot prove that the current configuration matches what
-was in use at the time of the snapshot, supplying *--force* assures
-libvirt that the snapshot is compatible with the current configuration
-(and if it is not, the domain will likely fail to run).  The other is
-the case of reverting from a running domain to an active state where a
-new hypervisor has to be created rather than reusing the existing
-hypervisor, because it implies drawbacks such as breaking any existing
-VNC or Spice connections; this condition happens with an active
-snapshot that uses a provably incompatible configuration, as well as
-with an inactive snapshot that is combined with the *--start* or
-*--pause* flag.
+requires the use of *--force* to proceed:
+
+  * One is the case of a snapshot that lacks full domain information for
+    reverting configuration (such as snapshots created prior to libvirt
+    0.9.5); since libvirt cannot prove that the current configuration matches
+    what was in use at the time of the snapshot, supplying *--force* assures
+    libvirt that the snapshot is compatible with the current configuration
+    (and if it is not, the domain will likely fail to run).
+
+  * The other is the case of reverting from a running domain to an active
+    state where a new hypervisor has to be created rather than reusing the
+    existing hypervisor, because it implies drawbacks such as breaking any
+    existing VNC or Spice connections; this condition happens with an active
+    snapshot that uses a provably incompatible configuration, as well as with
+    an inactive snapshot that is combined with the *--start* or *--pause*
+    flag.
 
 
 snapshot-delete
-- 
2.24.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/3] docs: Reformat snapshot-revert force reasons
Posted by Daniel Henrique Barboza 6 years, 1 month ago

On 1/2/20 1:00 PM, Michael Weiser wrote:
> Reformat explanations of the snapshot-revert force reasons in
> preparation for more to be added. This is a simple reformat without any
> wording changes.
> 
> Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
> Cc: Cole Robinson <crobinso@redhat.com>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   docs/manpages/virsh.rst | 30 ++++++++++++++++--------------
>   1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> index fea0527caf..f5f962cba1 100644
> --- a/docs/manpages/virsh.rst
> +++ b/docs/manpages/virsh.rst
> @@ -6952,20 +6952,22 @@ transient domains cannot be inactive, it is required to use one of these
>   flags when reverting to a disk snapshot of a transient domain.
>   
>   There are two cases where a snapshot revert involves extra risk, which
> -requires the use of *--force* to proceed.  One is the case of a
> -snapshot that lacks full domain information for reverting
> -configuration (such as snapshots created prior to libvirt 0.9.5);
> -since libvirt cannot prove that the current configuration matches what
> -was in use at the time of the snapshot, supplying *--force* assures
> -libvirt that the snapshot is compatible with the current configuration
> -(and if it is not, the domain will likely fail to run).  The other is
> -the case of reverting from a running domain to an active state where a
> -new hypervisor has to be created rather than reusing the existing
> -hypervisor, because it implies drawbacks such as breaking any existing
> -VNC or Spice connections; this condition happens with an active
> -snapshot that uses a provably incompatible configuration, as well as
> -with an inactive snapshot that is combined with the *--start* or
> -*--pause* flag.
> +requires the use of *--force* to proceed:
> +
> +  * One is the case of a snapshot that lacks full domain information for
> +    reverting configuration (such as snapshots created prior to libvirt
> +    0.9.5); since libvirt cannot prove that the current configuration matches
> +    what was in use at the time of the snapshot, supplying *--force* assures
> +    libvirt that the snapshot is compatible with the current configuration
> +    (and if it is not, the domain will likely fail to run).
> +
> +  * The other is the case of reverting from a running domain to an active
> +    state where a new hypervisor has to be created rather than reusing the
> +    existing hypervisor, because it implies drawbacks such as breaking any
> +    existing VNC or Spice connections; this condition happens with an active
> +    snapshot that uses a provably incompatible configuration, as well as with
> +    an inactive snapshot that is combined with the *--start* or *--pause*
> +    flag.
>   
>   
>   snapshot-delete
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list