docs/manpages/virsh.rst | 39 ++++++++++++++++++++++++--------------- src/qemu/qemu_driver.c | 9 +++++++++ 2 files changed, 33 insertions(+), 15 deletions(-)
This series marks restore of an inactive qemu snapshot while there is managed saved state as risky due to the reasons explained in patch 1 and 3. Patch 2 is a simple reformatting of the documentation with no other changes in preparation of addition of more reasons why reverts might need to be forced. Changes from v2: - fix manpage typo exising -> existing - change manpage qemu hypervisor name case to QEMU Changes from v1: - reword error message to "error: revert requires force: snapshot without memory state, removal of existing managed saved state strongly recommended to avoid corruption" - add documentation of the new behaviour Michael Weiser (3): qemu: Warn of restore with managed save being risky docs: Reformat snapshot-revert force reasons docs: Add snapshot-revert qemu managedsave force docs/manpages/virsh.rst | 39 ++++++++++++++++++++++++--------------- src/qemu/qemu_driver.c | 9 +++++++++ 2 files changed, 33 insertions(+), 15 deletions(-) -- 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 1/3/20 3:43 PM, Michael Weiser wrote: > This series marks restore of an inactive qemu snapshot while there is > managed saved state as risky due to the reasons explained in patch 1 and > 3. Patch 2 is a simple reformatting of the documentation with no other > changes in preparation of addition of more reasons why reverts might > need to be forced. > > Changes from v2: > - fix manpage typo exising -> existing > - change manpage qemu hypervisor name case to QEMU > > Changes from v1: > - reword error message to "error: revert requires force: snapshot > without memory state, removal of existing managed saved state strongly > recommended to avoid corruption" > - add documentation of the new behaviour > > Michael Weiser (3): > qemu: Warn of restore with managed save being risky > docs: Reformat snapshot-revert force reasons > docs: Add snapshot-revert qemu managedsave force All patches: Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 1/3/20 7:52 PM, Daniel Henrique Barboza wrote: > > > On 1/3/20 3:43 PM, Michael Weiser wrote: >> This series marks restore of an inactive qemu snapshot while there is >> managed saved state as risky due to the reasons explained in patch 1 and >> 3. Patch 2 is a simple reformatting of the documentation with no other >> changes in preparation of addition of more reasons why reverts might >> need to be forced. >> >> Changes from v2: >> - fix manpage typo exising -> existing >> - change manpage qemu hypervisor name case to QEMU >> >> Changes from v1: >> - reword error message to "error: revert requires force: snapshot >> without memory state, removal of existing managed saved state strongly >> recommended to avoid corruption" >> - add documentation of the new behaviour >> >> Michael Weiser (3): >> qemu: Warn of restore with managed save being risky >> docs: Reformat snapshot-revert force reasons >> docs: Add snapshot-revert qemu managedsave force > > > All patches: > > > Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> > And pushed now. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Hello Michal and Daniel, On Fri, Jan 10, 2020 at 11:01:14AM +0100, Michal Privoznik wrote: > > > This series marks restore of an inactive qemu snapshot while there is > > > managed saved state as risky due to the reasons explained in patch 1 and > > > 3. Patch 2 is a simple reformatting of the documentation with no other > > > changes in preparation of addition of more reasons why reverts might > > > need to be forced. > > > > > > Changes from v2: > > > - fix manpage typo exising -> existing > > > - change manpage qemu hypervisor name case to QEMU > > > > > > Changes from v1: > > > - reword error message to "error: revert requires force: snapshot > > > without memory state, removal of existing managed saved state strongly > > > recommended to avoid corruption" > > > - add documentation of the new behaviour > > > > > > Michael Weiser (3): > > > qemu: Warn of restore with managed save being risky > > > docs: Reformat snapshot-revert force reasons > > > docs: Add snapshot-revert qemu managedsave force > > All patches: > > Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> > And pushed now. Thank you for your help on this! -- Thanks, Michael -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2026 Red Hat, Inc.