Cleanups after adopting g_get_*_dir()

[libvirt] [PATCH 10/42] tools: Don't check the output of virGetUserCacheDirectory()

Posted by Fabiano Fidêncio 6 years, 1 month ago

virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 tools/vsh.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index bbb6227130..b982aeb359 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -2913,11 +2913,6 @@ vshReadlineInit(vshControl *ctl)
      */
     userdir = virGetUserCacheDirectory();
 
-    if (userdir == NULL) {
-        vshError(ctl, "%s", _("Could not determine home directory"));
-        goto cleanup;
-    }
-
     ctl->historydir = g_strdup_printf("%s/%s", userdir, ctl->name);
 
     ctl->historyfile = g_strdup_printf("%s/history", ctl->historydir);
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 10/42] tools: Don't check the output of virGetUserCacheDirectory()

Posted by Ján Tomko 6 years, 1 month ago

On Thu, Dec 19, 2019 at 11:04:15AM +0100, Fabiano Fidêncio wrote:
>virGetUserCacheDirectory() *never* *ever* returns NULL, making the
>checks for it completely unnecessary.
>
>Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>---
> tools/vsh.c | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list