From nobody Mon Feb 9 18:18:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576749933; cv=none; d=zohomail.com; s=zohoarc; b=QqbwmGG1HXMKgkCH8tAls/tIR7bUCReM/EeEAGfoOQRjoLtwXezOis21xrkYUtAWjECjQMCuSY01S/M1jBjtsFnguq2VvuH19T+/hXEkS8V6tErplAgeRPzalMRXpqThPuIsh95heBZ2IoveHJhw770OyYdYoBEJ5VPaNOXIrAE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576749933; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fYGrFU3xJyAK2fF8tB0VXWav9OttPE33IAO9CZbzF8s=; b=VVr51Qo4luOwbq3PwnIXw1BjicKSuISo3E2ZU8/sHfR4a77MpzRQOUkC5Rdi4XzQJMbHm73HVjvvRMMEHfABDLwJmmWqWTMaPFTUgZFlvwEzhtR392MHu0Z4vwk9alKB6p8VDrmQ67HvydmMd6xF4iJ+yqqgPQ2Si9Pd/dy52lc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1576749933995257.3106195159636; Thu, 19 Dec 2019 02:05:33 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324--u_Zw8kVM32mUuW5EvUHzA-1; Thu, 19 Dec 2019 05:05:30 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7586FDB6A; Thu, 19 Dec 2019 10:05:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D42568890; Thu, 19 Dec 2019 10:05:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F22B0827E6; Thu, 19 Dec 2019 10:05:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBJA537K010855 for ; Thu, 19 Dec 2019 05:05:03 -0500 Received: by smtp.corp.redhat.com (Postfix) id E108326E61; Thu, 19 Dec 2019 10:05:03 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F6F026DF9; Thu, 19 Dec 2019 10:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576749932; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fYGrFU3xJyAK2fF8tB0VXWav9OttPE33IAO9CZbzF8s=; b=Hy7K6pLYeTVBUIpnxiKOqhWnn9OguKM19jNKzHCI3gQlcV5o92PygSXqtAjiDZSK1laGwV a6frSkwEEDj3NcxtqzugvOd8cpg8Jb1ICOO6GIP1+a6fxU38UpxgrkgdMTr+Fi8hJjoWSm ELoiBW97yZ964g52coeBBZFGg0EF1bE= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Thu, 19 Dec 2019 11:04:15 +0100 Message-Id: <20191219100447.210836-11-fidencio@redhat.com> In-Reply-To: <20191219100447.210836-1-fidencio@redhat.com> References: <20191219100447.210836-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 10/42] tools: Don't check the output of virGetUserCacheDirectory() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: -u_Zw8kVM32mUuW5EvUHzA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: J=C3=A1n Tomko --- tools/vsh.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index bbb6227130..b982aeb359 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2913,11 +2913,6 @@ vshReadlineInit(vshControl *ctl) */ userdir =3D virGetUserCacheDirectory(); =20 - if (userdir =3D=3D NULL) { - vshError(ctl, "%s", _("Could not determine home directory")); - goto cleanup; - } - ctl->historydir =3D g_strdup_printf("%s/%s", userdir, ctl->name); =20 ctl->historyfile =3D g_strdup_printf("%s/history", ctl->historydir); --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list