Remove VIR_FILE_*_SEPARATOR_*

[libvirt] [PATCH 0/2] Remove VIR_FILE__SEPARATOR_

Fabiano Fidêncio posted 2 patches 4 years, 4 months ago

Download series mbox

Failed in applying to current master (apply log)

src/util/virfile.c |  2 +-
src/util/virfile.h | 19 -------------------
2 files changed, 1 insertion(+), 20 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Remove VIR_FILE_*_SEPARATOR_*

Posted by Fabiano Fidêncio 4 years, 4 months ago

Let's use the defines provided by GLib, instead of keeping our own.

Fabiano Fidêncio (2):
  util: Use G_DIR_SEPARATOR instead of VIR_FILE_DIR_SEPARATOR
  util: Remove VIR_FILE_*_SEPARATOR*

 src/util/virfile.c |  2 +-
 src/util/virfile.h | 19 -------------------
 2 files changed, 1 insertion(+), 20 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Remove VIR_FILE_*_SEPARATOR_*

Posted by Cole Robinson 4 years, 4 months ago

On 12/18/19 3:17 PM, Fabiano Fidêncio wrote:
> Let's use the defines provided by GLib, instead of keeping our own.
> 
> Fabiano Fidêncio (2):
>   util: Use G_DIR_SEPARATOR instead of VIR_FILE_DIR_SEPARATOR
>   util: Remove VIR_FILE_*_SEPARATOR*
> 
>  src/util/virfile.c |  2 +-
>  src/util/virfile.h | 19 -------------------
>  2 files changed, 1 insertion(+), 20 deletions(-)
> 

I'm guessing this series is based on your previous virFile removals. An
independent series should be based on master, otherwise 'git am' gets
confused about missing ancestors which makes it harder to test+review.
I applied manually though, so:

Reviewed-by: Cole Robinson <crobinso@redhat.com>

Possible follow up: virFileRemoveLastComponent only has one user, and it
may be pretty close to g_path_get_dirname(), so that can possibly be
dropped. Might want to check the glib implementation though

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list