From nobody Fri May 3 12:49:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576700252; cv=none; d=zohomail.com; s=zohoarc; b=Wq1UrU5qWG54fYi3NrU0P3sAyjpdmrRPhRF816COw2Q6XjNGvwWcP6bIA+eRwagrwrrjxIk9ZcwNFxs88bPuY5Of+mcjxqr73aZ+k+7Hu3fJzrrEbqg9+G7Zr4GKIVV8cK1RlmpQfpzETQjLl7CjsmeFaTdyn5+sXiKL5fbdJGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576700252; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RMDsZduRP2CvRb8KvKfRo+kY/Nlt77bVN2CdFGOUM74=; b=Yg0I99zv915ZSPPf9qmF/gpwMo/UhHdQmZLrFj4bsX+mHqMHKRAgtZKmmJ54sbXX8nlPaaSosxk8u6OEAJZO4hHWpeW45yN5vwVg4Hk1GWFDwxZWsEM+L+8cQqCcm7pbj4PWpD3JFznSQ2ovudD1toSjFbLiBRh43LER4dYtYfM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576700252759601.4230627068159; Wed, 18 Dec 2019 12:17:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-b2YketUMMOeTvZSYQgX5cA-1; Wed, 18 Dec 2019 15:17:29 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 187B218B9FD3; Wed, 18 Dec 2019 20:17:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E31375D9E5; Wed, 18 Dec 2019 20:17:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4B785827D4; Wed, 18 Dec 2019 20:17:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBIKHKY1019923 for ; Wed, 18 Dec 2019 15:17:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 56B626046B; Wed, 18 Dec 2019 20:17:20 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB40A620A7; Wed, 18 Dec 2019 20:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576700251; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RMDsZduRP2CvRb8KvKfRo+kY/Nlt77bVN2CdFGOUM74=; b=FAnRa3NPsMGysrBKDqTd8UKemRLA7eFmXwvlHMFYg4cBsGJt4kxSQW3dgCo75RjGYlo1HN Xh5/VDQhZXD54pnj5iQ6ZjfLYeMAO0k6zq87lLU1CLFJdVwZl5ko7KJpDV7Aq0ttxJMTyW AHtTCzF/HyR9rs6aHuaE29bJsTAZJTY= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Wed, 18 Dec 2019 21:17:12 +0100 Message-Id: <20191218201713.1912557-2-fidencio@redhat.com> In-Reply-To: <20191218201713.1912557-1-fidencio@redhat.com> References: <20191218201713.1912557-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 1/2] util: Use G_DIR_SEPARATOR instead of VIR_FILE_DIR_SEPARATOR X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: b2YketUMMOeTvZSYQgX5cA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: Cole Robinson --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index b72d18b3d2..0f0d607c59 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3278,7 +3278,7 @@ virFileRemoveLastComponent(char *path) { char *tmp; =20 - if ((tmp =3D strrchr(path, VIR_FILE_DIR_SEPARATOR))) + if ((tmp =3D strrchr(path, G_DIR_SEPARATOR))) tmp[1] =3D '\0'; else path[0] =3D '\0'; --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri May 3 12:49:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576700262; cv=none; d=zohomail.com; s=zohoarc; b=XXFl7kG8UOtxlWNMgl6xqAkabIqOAl8I7MDhSgGiWBG+EEmU7KfG5n5FMp5ezgzy1UC++wmhF7M7jzxonvOA7HoyHuNDRycodQ8TKZ6sh9/g340SOYT4u7iLXd+PnhvpLGeo7aO/3G1wtlQFRVPLiRfPb2oa0sPoJ+6Fna8C5GQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576700262; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NXdsb+BxyQ81Yi/LN7h6r3IPN23y2Ws6TkrNmpOpmK0=; b=Ow3163CezCJoSxyFVVl/dOtN4XSKnCH6AliFbHRcGNpSbTqI/qch4g705Sagb8M2QaRczYw6ey43XsFx0IRWiUmKIiteBQUwOVeU0o9KkYW0dPkZ8ivCYgyQeK0eskHhUlOB94QQ0k8ZD6ZfaxF4I1fM2sXtKX9zjEiBb1fRpvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1576700262231760.695798535119; Wed, 18 Dec 2019 12:17:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-w1L60n1bOcmrUNbmp7Z7Ag-1; Wed, 18 Dec 2019 15:17:39 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D96D90436A; Wed, 18 Dec 2019 20:17:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 13CC11001B00; Wed, 18 Dec 2019 20:17:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B15CE18089CD; Wed, 18 Dec 2019 20:17:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBIKHLDV019934 for ; Wed, 18 Dec 2019 15:17:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4F71E6046B; Wed, 18 Dec 2019 20:17:21 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3A9563B81; Wed, 18 Dec 2019 20:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576700260; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NXdsb+BxyQ81Yi/LN7h6r3IPN23y2Ws6TkrNmpOpmK0=; b=RPY67BIeKDJWqg0X4lvBiV4xfdyRS11bLrGE8iiOGtTR+YMy2uKx9KMIZKbzY+MtWIIPYO NkJZy2GuTZ98HCt1UcnvPWIcjwliQcDmejaez/EtcbEv7rQoJFs9iVQKDewfnEaRJE5B2L nJgoXF/qK8cpqa3f9FrCmd8txRFZ/oo= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Wed, 18 Dec 2019 21:17:13 +0100 Message-Id: <20191218201713.1912557-3-fidencio@redhat.com> In-Reply-To: <20191218201713.1912557-1-fidencio@redhat.com> References: <20191218201713.1912557-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 2/2] util: Remove VIR_FILE_*_SEPARATOR* X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: w1L60n1bOcmrUNbmp7Z7Ag-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) None of those are used and we should prefer using the ones provided by GLib, as G_DIR_SEPARATOR, G_DIR_SEPARATOR_S, G_SEARCHPATH_SEPARATOR, and G_SEARCHPATH_SEPARATOR_S. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: Cole Robinson --- src/util/virfile.h | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/util/virfile.h b/src/util/virfile.h index 3fd1795813..264b12c03d 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -278,25 +278,6 @@ char *virFileBuildPath(const char *dir, const char *ext) G_GNUC_WARN_UNUSED_RESULT; =20 =20 -#ifdef WIN32 -/* On Win32, the canonical directory separator is the backslash, and - * the search path separator is the semicolon. Note that also the - * (forward) slash works as directory separator. - */ -# define VIR_FILE_DIR_SEPARATOR '\\' -# define VIR_FILE_DIR_SEPARATOR_S "\\" -# define VIR_FILE_PATH_SEPARATOR ';' -# define VIR_FILE_PATH_SEPARATOR_S ";" - -#else /* !WIN32 */ - -# define VIR_FILE_DIR_SEPARATOR '/' -# define VIR_FILE_DIR_SEPARATOR_S "/" -# define VIR_FILE_PATH_SEPARATOR ':' -# define VIR_FILE_PATH_SEPARATOR_S ":" - -#endif /* !WIN32 */ - int virFileAbsPath(const char *path, char **abspath) G_GNUC_WARN_UNUSED_RESULT; void virFileRemoveLastComponent(char *path); --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list