[libvirt] [PATCH v3 0/6] Fix virConnectRegisterCloseCallback and get rid of global variables

Marc Hartmayer posted 6 patches 2 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191101173548.7888-1-mhartmay@linux.ibm.com
src/libvirt-host.c                  |  12 +-
src/libvirt_remote.syms             |   1 +
src/remote/remote_daemon.c          |   4 +-
src/remote/remote_daemon.h          |   2 -
src/remote/remote_daemon_dispatch.c | 227 +++++++++++++++++++---------
src/rpc/gendispatch.pl              |   6 +
src/rpc/virnetserver.c              |  53 +++++--
src/rpc/virnetserver.h              |   2 +
8 files changed, 217 insertions(+), 90 deletions(-)

[libvirt] [PATCH v3 0/6] Fix virConnectRegisterCloseCallback and get rid of global variables

Posted by Marc Hartmayer 2 weeks ago
After discussions with Peter and Pavel at the KVM forum, I am now
sending a v3 of this series after more than a year... sorry for that
long delay!

The second patch of this patch series fixes the behavior of
virConnectRegisterCloseCallback.

The subsequent patches remove the need to have the global variables
'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in
combination with the fixed behavior of
virConnectRegisterCloseCallback.

Changelog:
 + v2->v3:
   - Rebased to current master
   - Added Johns r-b to the first patch, all other r-b's I have
     dropped as there were to many changes in the meantime
   - Removed accepted patches
   - Dropped patches 8 and 9
 + v1->v2:
   - Removed accepted patches
   - Removed NACKed patches
   - Added r-b to patch 5
   - Worked in comments
   - Rebased
   - Added patches 7-9

Marc Hartmayer (6):
  rpc: use the return value of virObjectRef directly
  virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
    connectRegisterCloseCallback
  remote: Save reference to program in daemonClientEventCallback
  remote: Use domainClientEventCallbacks for
    remoteReplayConnectionClosedEvent
  rpc: Introduce virNetServerGetProgramLocked helper function
  remote/rpc: Use virNetServerGetProgram() to determine the program

 src/libvirt-host.c                  |  12 +-
 src/libvirt_remote.syms             |   1 +
 src/remote/remote_daemon.c          |   4 +-
 src/remote/remote_daemon.h          |   2 -
 src/remote/remote_daemon_dispatch.c | 227 +++++++++++++++++++---------
 src/rpc/gendispatch.pl              |   6 +
 src/rpc/virnetserver.c              |  53 +++++--
 src/rpc/virnetserver.h              |   2 +
 8 files changed, 217 insertions(+), 90 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list