[libvirt] [PATCH v4 0/7] Fix virConnectRegisterCloseCallback and get rid of global variables

Marc Hartmayer posted 7 patches 4 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191114174425.13583-1-mhartmay@linux.ibm.com
src/libvirt-host.c                  |  16 +-
src/libvirt_remote.syms             |   1 +
src/remote/remote_daemon.c          |   4 +-
src/remote/remote_daemon.h          |   2 -
src/remote/remote_daemon_dispatch.c | 363 +++++++++++++++++-----------
src/rpc/gendispatch.pl              |   6 +
src/rpc/virnetserver.c              |  53 +++-
src/rpc/virnetserver.h              |   2 +
8 files changed, 293 insertions(+), 154 deletions(-)
[libvirt] [PATCH v4 0/7] Fix virConnectRegisterCloseCallback and get rid of global variables
Posted by Marc Hartmayer 4 years, 5 months ago
The second patch of this patch series fixes the behavior of
virConnectRegisterCloseCallback.

The subsequent patches remove the need to have the global variables
'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in
combination with the fixed behavior of
virConnectRegisterCloseCallback.

Changelog:
 + v3->v4:
   - Rebased to current master
   - Added Pavel's r-bs
   - Worked in Pavel's comments
   - Added patch "remote: shrink the critical sections" in preparation
     for patch "remote/rpc: Use virNetServerGetProgram() to determine
     the program"
 + v2->v3:
   - Rebased to current master
   - Added Johns r-b to the first patch, all other r-b's I have
     dropped as there were to many changes in the meantime
   - Removed accepted patches
   - Dropped patches 8 and 9
 + v1->v2:
   - Removed accepted patches
   - Removed NACKed patches
   - Added r-b to patch 5
   - Worked in comments
   - Rebased
   - Added patches 7-9

Marc Hartmayer (7):
  rpc: use the return value of virObjectRef directly
  virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
    connectRegisterCloseCallback
  remote: Save reference to program in daemonClientEventCallback
  remote: Use domainClientEventCallbacks for
    remoteReplayConnectionClosedEvent
  rpc: Introduce virNetServerGetProgramLocked helper function
  remote: shrink the critical sections
  remote/rpc: Use virNetServerGetProgram() to determine the program

 src/libvirt-host.c                  |  16 +-
 src/libvirt_remote.syms             |   1 +
 src/remote/remote_daemon.c          |   4 +-
 src/remote/remote_daemon.h          |   2 -
 src/remote/remote_daemon_dispatch.c | 363 +++++++++++++++++-----------
 src/rpc/gendispatch.pl              |   6 +
 src/rpc/virnetserver.c              |  53 +++-
 src/rpc/virnetserver.h              |   2 +
 8 files changed, 293 insertions(+), 154 deletions(-)

-- 
2.21.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 0/7] Fix virConnectRegisterCloseCallback and get rid of global variables
Posted by Marc Hartmayer 4 years, 4 months ago
On Thu, Nov 14, 2019 at 06:44 PM +0100, Marc Hartmayer <mhartmay@linux.ibm.com> wrote:
> The second patch of this patch series fixes the behavior of
> virConnectRegisterCloseCallback.
>
> The subsequent patches remove the need to have the global variables
> 'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in
> combination with the fixed behavior of
> virConnectRegisterCloseCallback.
>
> Changelog:
>  + v3->v4:
>    - Rebased to current master
>    - Added Pavel's r-bs
>    - Worked in Pavel's comments
>    - Added patch "remote: shrink the critical sections" in preparation
>      for patch "remote/rpc: Use virNetServerGetProgram() to determine
>      the program"
>  + v2->v3:
>    - Rebased to current master
>    - Added Johns r-b to the first patch, all other r-b's I have
>      dropped as there were to many changes in the meantime
>    - Removed accepted patches
>    - Dropped patches 8 and 9
>  + v1->v2:
>    - Removed accepted patches
>    - Removed NACKed patches
>    - Added r-b to patch 5
>    - Worked in comments
>    - Rebased
>    - Added patches 7-9
>
> Marc Hartmayer (7):
>   rpc: use the return value of virObjectRef directly
>   virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
>     connectRegisterCloseCallback
>   remote: Save reference to program in daemonClientEventCallback
>   remote: Use domainClientEventCallbacks for
>     remoteReplayConnectionClosedEvent
>   rpc: Introduce virNetServerGetProgramLocked helper function
>   remote: shrink the critical sections
>   remote/rpc: Use virNetServerGetProgram() to determine the program
>
>  src/libvirt-host.c                  |  16 +-
>  src/libvirt_remote.syms             |   1 +
>  src/remote/remote_daemon.c          |   4 +-
>  src/remote/remote_daemon.h          |   2 -
>  src/remote/remote_daemon_dispatch.c | 363 +++++++++++++++++-----------
>  src/rpc/gendispatch.pl              |   6 +
>  src/rpc/virnetserver.c              |  53 +++-
>  src/rpc/virnetserver.h              |   2 +
>  8 files changed, 293 insertions(+), 154 deletions(-)
>
> -- 
> 2.21.0
>
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

Polite ping :)

-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list