[libvirt] [PATCH 0/3] Update rebootTimeout range to 0..0xffff

Han Han posted 3 patches 1 week ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191008083644.16154-1-hhan@redhat.com
docs/formatdomain.html.in                     |  5 ++--
src/conf/domain_conf.c                        |  6 ++--
.../reboot-timeout-disabled.args              | 28 -------------------
.../reboot-timeout-disabled.xml               | 24 ----------------
.../reboot-timeout-disabled.xml               | 26 -----------------
5 files changed, 6 insertions(+), 83 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.args
delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.xml
delete mode 100644 tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml

[libvirt] [PATCH 0/3] Update rebootTimeout range to 0..0xffff

Posted by Han Han 1 week ago
Since qemu v4.0.0(commit ee5d0f89de3), reboot-timeout valid range was
set 0~0xffff. Update libvirt codes, docs, tests for that change.

I am not sure if po files should be updated. If so, please point it out.

Han Han (3):
  conf: Set rebootTimeout valid range to 0..0xffff
  tests: Remove test reboot-timeout-disabled
  docs: Update docs on rebootTimeout valid value range

 docs/formatdomain.html.in                     |  5 ++--
 src/conf/domain_conf.c                        |  6 ++--
 .../reboot-timeout-disabled.args              | 28 -------------------
 .../reboot-timeout-disabled.xml               | 24 ----------------
 .../reboot-timeout-disabled.xml               | 26 -----------------
 5 files changed, 6 insertions(+), 83 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.args
 delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.xml
 delete mode 100644 tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Update rebootTimeout range to 0..0xffff

Posted by Michal Privoznik 1 week ago
On 10/8/19 10:36 AM, Han Han wrote:
> Since qemu v4.0.0(commit ee5d0f89de3), reboot-timeout valid range was
> set 0~0xffff. Update libvirt codes, docs, tests for that change.
> 
> I am not sure if po files should be updated. If so, please point it out.

No, they are refreshed just before release.
However, I'm not sure we can do this, see 1/3.

> 
> Han Han (3):
>    conf: Set rebootTimeout valid range to 0..0xffff
>    tests: Remove test reboot-timeout-disabled
>    docs: Update docs on rebootTimeout valid value range
> 
>   docs/formatdomain.html.in                     |  5 ++--
>   src/conf/domain_conf.c                        |  6 ++--
>   .../reboot-timeout-disabled.args              | 28 -------------------
>   .../reboot-timeout-disabled.xml               | 24 ----------------
>   .../reboot-timeout-disabled.xml               | 26 -----------------
>   5 files changed, 6 insertions(+), 83 deletions(-)
>   delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.args
>   delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.xml
>   delete mode 100644 tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml
> 

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list