From nobody Fri Mar 29 11:26:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570523889; cv=none; d=zoho.com; s=zohoarc; b=a6OGBS0ESePsMZsCKut0uc70m66M9oJUGL5V2IPfgx7Oh37jX5TjVY4s6fTksMNbSSYRtrsFWv3tAuvZQXRwWvveNJW0jSUw70ozR7s34HQu0gJ8zKecTpV4EXuoLBCCPmuMsP0vOBLW9d5eB6zkIezkdfjBcjZrsMs9IAx7UTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570523889; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=h38SfWrGfpi2iBVaYa6MjxKkGoHZHay6Dgw30jw2ank=; b=Zsfnyn7uqTBRZVlvj2cYsw7UVwZNdZDeXBhadLHrrJHkbQLXi+8/F2s7p6x1644xe8IC97SL9QzVlKw5HaHCSxOlSfTrHOScuuD80+Gla/e9iuZpB2MlxKhNrpQ60vi1mfHuzi8pI63uNqCD8BjWDgz1ATtg0Bn6HLqqHKhmIlc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570523889876927.4415985304555; Tue, 8 Oct 2019 01:38:09 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3824806CF; Tue, 8 Oct 2019 08:38:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FD0B5D772; Tue, 8 Oct 2019 08:38:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 968784E58A; Tue, 8 Oct 2019 08:38:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x988ai3T013404 for ; Tue, 8 Oct 2019 04:36:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5C79C196AE; Tue, 8 Oct 2019 08:36:44 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50C9F19C68; Tue, 8 Oct 2019 08:36:43 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Tue, 8 Oct 2019 16:36:42 +0800 Message-Id: <20191008083644.16154-2-hhan@redhat.com> In-Reply-To: <20191008083644.16154-1-hhan@redhat.com> References: <20191008083644.16154-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 08 Oct 2019 08:38:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Adjust valid range of rebootTimeout according to qemu-4.0.0 commit ee5d0f89de3. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a53cd6a725..57ab254f52 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18090,10 +18090,12 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, /* that was really just for the check if it is there */ =20 if (virStrToLong_i(tmp, NULL, 0, &def->os.bios.rt_delay) < 0 || - def->os.bios.rt_delay < -1 || def->os.bios.rt_delay > 6553= 5) { + def->os.bios.rt_delay < 0 || def->os.bios.rt_delay > 65535= ) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("invalid value for rebootTimeout, " - "must be in range [-1,65535]")); + "must be in range [0,65535]. " + "To disable reboot, " + "just remove this attribute.")); return -1; } def->os.bios.rt_set =3D true; --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Mar 29 11:26:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570523989; cv=none; d=zoho.com; s=zohoarc; b=NljGxFY+jYTHp7pp2pCMAL7aoTE1h1SYR7e+/kghHKRUFMeGU1LUoQTCo5nah3XrU75aYD+t5ApsU8BYa+k2/arhs8V2oCx0488WGIQIm7+5qspB6QJ/I1hkOEu7gQISAO1yLjAd4sJQFIU5RgY+uaJYfPTDhHHcL6zzNeF3HsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570523989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=x7R0TpCecfET9IQsOfQTEMsp+N8142By3UuYtW/WtRo=; b=lhqc3P3SEm2ZWgBtsiSSvrJ75Dli+uDPWrgdIuq1N5/TdywxB8Da9ddMAsU3hIS4PfmcrtaUTMFZ0hkfRWSI1GLOZ6J5mh99SmyJiUXpn+ibJTsXo4GYAFhAIJvqmSFrizQsaIhPvDY56g56ilHHG3gWDm8vVeZYwOlStE3h1hs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570523989793108.25440670537989; Tue, 8 Oct 2019 01:39:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E636E302C07C; Tue, 8 Oct 2019 08:39:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEEA76012A; Tue, 8 Oct 2019 08:39:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7FF39180B536; Tue, 8 Oct 2019 08:39:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x988ajSD013412 for ; Tue, 8 Oct 2019 04:36:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id E8FE7194B2; Tue, 8 Oct 2019 08:36:45 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC83F19C68; Tue, 8 Oct 2019 08:36:44 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Tue, 8 Oct 2019 16:36:43 +0800 Message-Id: <20191008083644.16154-3-hhan@redhat.com> In-Reply-To: <20191008083644.16154-1-hhan@redhat.com> References: <20191008083644.16154-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH 2/3] tests: Remove test reboot-timeout-disabled X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 08 Oct 2019 08:39:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Reboot timeout is disabled by default in qemu. And -1 is invalid value for reboot-timeout parameter after qemu-4.0.0. Signed-off-by: Han Han --- .../reboot-timeout-disabled.args | 28 ------------------- .../reboot-timeout-disabled.xml | 24 ---------------- .../reboot-timeout-disabled.xml | 26 ----------------- 3 files changed, 78 deletions(-) delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.args delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-disabled.xml delete mode 100644 tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml diff --git a/tests/qemuxml2argvdata/reboot-timeout-disabled.args b/tests/qe= muxml2argvdata/reboot-timeout-disabled.args deleted file mode 100644 index d5973b4192..0000000000 --- a/tests/qemuxml2argvdata/reboot-timeout-disabled.args +++ /dev/null @@ -1,28 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/tmp/lib/domain--1-QEMUGuest1 \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.local/share \ -XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.cache \ -XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \ -QEMU_AUDIO_DRV=3Dnone \ -/usr/bin/qemu-system-i686 \ --name QEMUGuest1 \ --S \ --machine pc,accel=3Dtcg,usb=3Doff,dump-guest-core=3Doff \ --m 214 \ --realtime mlock=3Doff \ --smp 6,sockets=3D6,cores=3D1,threads=3D1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,path=3D/tmp/lib/domain--1-QEMUGuest1/moni= tor.sock,\ -server,nowait \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --no-acpi \ --boot reboot-timeout=3D-1 \ --usb diff --git a/tests/qemuxml2argvdata/reboot-timeout-disabled.xml b/tests/qem= uxml2argvdata/reboot-timeout-disabled.xml deleted file mode 100644 index 8af83c5a42..0000000000 --- a/tests/qemuxml2argvdata/reboot-timeout-disabled.xml +++ /dev/null @@ -1,24 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 6 - - hvm - - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i686 - - - - - - - diff --git a/tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml b/tests/q= emuxml2xmloutdata/reboot-timeout-disabled.xml deleted file mode 100644 index 29b608af0a..0000000000 --- a/tests/qemuxml2xmloutdata/reboot-timeout-disabled.xml +++ /dev/null @@ -1,26 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - 6 - - hvm - - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i686 - -
- - - - - - - --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Mar 29 11:26:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570524000; cv=none; d=zoho.com; s=zohoarc; b=mIOEBanBnMowZQnd0M1PlweMDd8UQK6dS+5oIkfj+d/SLcC6vBGeIXHvNs9D+IOYiF6+2XCB28wqS1SLDn6B5DO/Dz1XxJUg57KJRcFBl5RgnA8+2TvJuwRZOnsJLgElJB6lA3diTjLaND343BUMLe3kL3PUdAXB2Jaw0XJT+KQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570524000; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=otCT6KLfsZ9WeGEMM0bymdLnkAXpRyz2KCBNDtObB4o=; b=J+MwBPAvbXFTa9tnVa9M/c4RpdnzcmlEX0r/CPETTajRx42SPhMsx9KK6z24l9fNMnzueeKpzFmfTA55chxKCw/r8pQ8mL16J6AUvK3zD0bE0gWO/z/eRKE+VBo8G9RKjCuG/jCeIxmmnsxDLHrvBbyjUNDz8eS5MYTGkYxvtoQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570524000321312.55550028616483; Tue, 8 Oct 2019 01:40:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66A658771C; Tue, 8 Oct 2019 08:39:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4208160A35; Tue, 8 Oct 2019 08:39:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0785F4EE95; Tue, 8 Oct 2019 08:39:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x988al2p013420 for ; Tue, 8 Oct 2019 04:36:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8122F194B2; Tue, 8 Oct 2019 08:36:47 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 756A719C68; Tue, 8 Oct 2019 08:36:46 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Tue, 8 Oct 2019 16:36:44 +0800 Message-Id: <20191008083644.16154-4-hhan@redhat.com> In-Reply-To: <20191008083644.16154-1-hhan@redhat.com> References: <20191008083644.16154-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH 3/3] docs: Update docs on rebootTimeout valid value range X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 08 Oct 2019 08:39:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- docs/formatdomain.html.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 647f96f651..8a6f289df7 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -274,9 +274,8 @@ Since 0.10.2 (QEMU only) there is another attribute, rebootTimeout that controls whether and after how long the guest should start booting - again in case the boot fails (according to BIOS). The value is - in milliseconds with maximum of 65535 and special - value -1 disables the reboot. + again in case the boot fails (according to BIOS). The value is in + milliseconds from 0 to 65535. =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list