admin: fix memory leak of typed parameters getting client info

[libvirt] [PATCH] admin: fix memory leak of typed parameters getting client info

Daniel P. Berrangé posted 1 patch 4 years, 6 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190930155714.12154-1-berrange@redhat.com

src/admin/admin_server.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[libvirt] [PATCH] admin: fix memory leak of typed parameters getting client info

Posted by Daniel P. Berrangé 4 years, 6 months ago

In the error code path, the temporary parameters are not freed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/admin/admin_server.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c
index 248df3f795..0d6091937d 100644
--- a/src/admin/admin_server.c
+++ b/src/admin/admin_server.c
@@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client,
     ret = 0;
 
  cleanup:
+    if (tmpparams)
+        virTypedParamsFree(tmpparams, *nparams);
     virObjectUnref(identity);
     VIR_FREE(sock_addr);
     return ret;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] admin: fix memory leak of typed parameters getting client info

Posted by Daniel Henrique Barboza 4 years, 6 months ago


On 9/30/19 12:57 PM, Daniel P. Berrangé wrote:
> In the error code path, the temporary parameters are not freed.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/admin/admin_server.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c
> index 248df3f795..0d6091937d 100644
> --- a/src/admin/admin_server.c
> +++ b/src/admin/admin_server.c
> @@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client,
>       ret = 0;
>   
>    cleanup:
> +    if (tmpparams)
> +        virTypedParamsFree(tmpparams, *nparams);
>       virObjectUnref(identity);
>       VIR_FREE(sock_addr);
>       return ret;

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list