From nobody Sun May 5 01:54:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569859045; cv=none; d=zoho.com; s=zohoarc; b=VOIbE6p2rYgNaMT6gwIFtze+wvXQ0PY8cUhiX/6U38j9IlXeCIWXt0jUaFFJdTXlpatebjFPe02ud83Krqg4Q/D0X3XXgOXjtWZzzZLvLjmAM4agXgnD/k4EOYyIfTh8lYrJ91mFSmnuVAYIHM2b2G5JA8/TApS+2GYBEpyn54Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569859045; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=ocqAXboqrETF2MrY5Vt3NvcWvEElL+ZkTAJGnfa7lgE=; b=VWN9vChUZc68n7cqcFYzuIeGVHKzSPg1/48U5vms2FzuW4PMdOwO5sMdszAvCmYtKkGT1rQl+3fD9Hq8YO8CP190Or95mXKMA9nJATnZLGYqLH9heNKI/GWTohhG6GJUkUPaGvShwd4eaTis8rjrpYiQaZCNrWn+k+TD8NIHmkg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1569859045659677.5547090021817; Mon, 30 Sep 2019 08:57:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81C9920E3; Mon, 30 Sep 2019 15:57:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33B045D6D0; Mon, 30 Sep 2019 15:57:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 809CA4E58A; Mon, 30 Sep 2019 15:57:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8UFvITr020676 for ; Mon, 30 Sep 2019 11:57:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id CC4846012A; Mon, 30 Sep 2019 15:57:18 +0000 (UTC) Received: from dhcp-17-55.lcy.redhat.com (unknown [10.42.17.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4906B60127; Mon, 30 Sep 2019 15:57:15 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 30 Sep 2019 16:57:14 +0100 Message-Id: <20190930155714.12154-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] admin: fix memory leak of typed parameters getting client info X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Mon, 30 Sep 2019 15:57:24 +0000 (UTC) In the error code path, the temporary parameters are not freed. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel Henrique Barboza --- src/admin/admin_server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c index 248df3f795..0d6091937d 100644 --- a/src/admin/admin_server.c +++ b/src/admin/admin_server.c @@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client, ret =3D 0; =20 cleanup: + if (tmpparams) + virTypedParamsFree(tmpparams, *nparams); virObjectUnref(identity); VIR_FREE(sock_addr); return ret; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list