[libvirt] [PATCH v2 0/3] unplug timeout changes for PPC64

Daniel Henrique Barboza posted 3 patches 1 week ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190911210529.11766-1-danielhb413@gmail.com
src/qemu/Makefile.inc.am    |  1 -
src/qemu/qemu_conf.h        |  3 +++
src/qemu/qemu_driver.c      | 11 +++++++++++
src/qemu/qemu_hotplug.c     | 21 +++++++++------------
src/qemu/qemu_hotplugpriv.h | 32 --------------------------------
tests/qemuhotplugtest.c     |  3 +--
6 files changed, 24 insertions(+), 47 deletions(-)
delete mode 100644 src/qemu/qemu_hotplugpriv.h

[libvirt] [PATCH v2 0/3] unplug timeout changes for PPC64

Posted by Daniel Henrique Barboza 1 week ago
This is a redesign of the previous patch series [1].
After the reviews of the first version, I ended up discarding
the idea of a qemu user configuration for the unplug timeout
value.  Instead, this patch series now handles the problematic
case of PPC64 guests with an exclusive PPC64 only timeout
value of 10 seconds.

Patch 3 now changes how the 'unplug timeout' message is
reported, using VIR_ERR_OPERATION_TIMEOUT instead of
VIR_ERR_OPERATION_FAILED and making it clearer that
the timeout does not equal to unplug failed.

[1] https://www.redhat.com/archives/libvir-list/2019-August/msg00698.html
 

Daniel Henrique Barboza (3):
  qemu: use a bigger unplug timeout for PPC64 guests
  qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime
  qemu_hotplug: make setvcpus timeout error message user-friendlier

 src/qemu/Makefile.inc.am    |  1 -
 src/qemu/qemu_conf.h        |  3 +++
 src/qemu/qemu_driver.c      | 11 +++++++++++
 src/qemu/qemu_hotplug.c     | 21 +++++++++------------
 src/qemu/qemu_hotplugpriv.h | 32 --------------------------------
 tests/qemuhotplugtest.c     |  3 +--
 6 files changed, 24 insertions(+), 47 deletions(-)
 delete mode 100644 src/qemu/qemu_hotplugpriv.h

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/3] unplug timeout changes for PPC64

Posted by Daniel Henrique Barboza 2 days ago
Ping

On 9/11/19 6:05 PM, Daniel Henrique Barboza wrote:
> This is a redesign of the previous patch series [1].
> After the reviews of the first version, I ended up discarding
> the idea of a qemu user configuration for the unplug timeout
> value.  Instead, this patch series now handles the problematic
> case of PPC64 guests with an exclusive PPC64 only timeout
> value of 10 seconds.
>
> Patch 3 now changes how the 'unplug timeout' message is
> reported, using VIR_ERR_OPERATION_TIMEOUT instead of
> VIR_ERR_OPERATION_FAILED and making it clearer that
> the timeout does not equal to unplug failed.
>
> [1] https://www.redhat.com/archives/libvir-list/2019-August/msg00698.html
>   
>
> Daniel Henrique Barboza (3):
>    qemu: use a bigger unplug timeout for PPC64 guests
>    qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime
>    qemu_hotplug: make setvcpus timeout error message user-friendlier
>
>   src/qemu/Makefile.inc.am    |  1 -
>   src/qemu/qemu_conf.h        |  3 +++
>   src/qemu/qemu_driver.c      | 11 +++++++++++
>   src/qemu/qemu_hotplug.c     | 21 +++++++++------------
>   src/qemu/qemu_hotplugpriv.h | 32 --------------------------------
>   tests/qemuhotplugtest.c     |  3 +--
>   6 files changed, 24 insertions(+), 47 deletions(-)
>   delete mode 100644 src/qemu/qemu_hotplugpriv.h
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list