[v3] unplug timeout changes for PPC64

[libvirt] [PATCH v3 0/3] unplug timeout changes for PPC64

Daniel Henrique Barboza posted 3 patches 4 years, 6 months ago

Diff against v2
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191018183634.15338-1-danielhb413@gmail.com

src/qemu/Makefile.inc.am                      |  1 -
src/qemu/qemu_hotplug.c                       | 28 ++++++++++++++-----
src/qemu/qemu_hotplug.h                       |  2 ++
tests/Makefile.am                             | 13 ++++++++-
.../qemuhotplugmock.c                         | 27 +++++++++---------
tests/qemuhotplugtest.c                       |  7 ++---
6 files changed, 51 insertions(+), 27 deletions(-)
rename src/qemu/qemu_hotplugpriv.h => tests/qemuhotplugmock.c (61%)

Expand all Fold all

[libvirt] [PATCH v3 0/3] unplug timeout changes for PPC64

Posted by Daniel Henrique Barboza 4 years, 6 months ago

changes in v3:
- redesigned patch 1 based on Cole Robinson feedback

v2: https://www.redhat.com/archives/libvir-list/2019-September/msg00447.html
v1: https://www.redhat.com/archives/libvir-list/2019-August/msg00698.html


Daniel Henrique Barboza (3):
  qemu_hotplug.c: adding qemuDomainGetUnplugTimeout
  qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime
  qemu_hotplug.c: user-friendlier setvcpus timeout error message

 src/qemu/Makefile.inc.am                      |  1 -
 src/qemu/qemu_hotplug.c                       | 28 ++++++++++++++-----
 src/qemu/qemu_hotplug.h                       |  2 ++
 tests/Makefile.am                             | 13 ++++++++-
 .../qemuhotplugmock.c                         | 27 +++++++++---------
 tests/qemuhotplugtest.c                       |  7 ++---
 6 files changed, 51 insertions(+), 27 deletions(-)
 rename src/qemu/qemu_hotplugpriv.h => tests/qemuhotplugmock.c (61%)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/3] unplug timeout changes for PPC64

Posted by Cole Robinson 4 years, 5 months ago

On 10/18/19 2:36 PM, Daniel Henrique Barboza wrote:
> changes in v3:
> - redesigned patch 1 based on Cole Robinson feedback
> 
> v2: https://www.redhat.com/archives/libvir-list/2019-September/msg00447.html
> v1: https://www.redhat.com/archives/libvir-list/2019-August/msg00698.html
> 
> 
> Daniel Henrique Barboza (3):
>   qemu_hotplug.c: adding qemuDomainGetUnplugTimeout
>   qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime
>   qemu_hotplug.c: user-friendlier setvcpus timeout error message
> 
>  src/qemu/Makefile.inc.am                      |  1 -
>  src/qemu/qemu_hotplug.c                       | 28 ++++++++++++++-----
>  src/qemu/qemu_hotplug.h                       |  2 ++
>  tests/Makefile.am                             | 13 ++++++++-
>  .../qemuhotplugmock.c                         | 27 +++++++++---------
>  tests/qemuhotplugtest.c                       |  7 ++---
>  6 files changed, 51 insertions(+), 27 deletions(-)
>  rename src/qemu/qemu_hotplugpriv.h => tests/qemuhotplugmock.c (61%)
> 

Reviewed and pushed. Sorry for the delay. One comment though: patch #1
was a mix of refactoring, and the PPC timeout change. In the future
please separate changes like that into two patches

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list