Couple of recent things from Coverity

[libvirt] [PATCH 0/4] Couple of recent things from Coverity

John Ferlan posted 4 patches 5 years, 4 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190723135811.26837-1-jferlan@redhat.com

src/qemu/qemu_monitor_json.c | 3 ---
src/util/vircommand.c        | 2 +-
tests/qemumonitorjsontest.c  | 3 +++
tests/virnetdaemontest.c     | 9 +++++----
4 files changed, 9 insertions(+), 8 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] Couple of recent things from Coverity

Posted by John Ferlan 5 years, 4 months ago

Some patches from recent changes for things Coverity has complained about

John Ferlan (4):
  qemu: Remove unnecessary check in qemuMonitorJSONGetJobInfoOne
  test: Return early in testQueryJobs
  util: Avoid possible error in virCommandMassClose
  tests: Avoid possible error in testExecRestart

 src/qemu/qemu_monitor_json.c | 3 ---
 src/util/vircommand.c        | 2 +-
 tests/qemumonitorjsontest.c  | 3 +++
 tests/virnetdaemontest.c     | 9 +++++----
 4 files changed, 9 insertions(+), 8 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Couple of recent things from Coverity

Posted by Peter Krempa 5 years, 4 months ago

On Tue, Jul 23, 2019 at 09:58:07 -0400, John Ferlan wrote:
> Some patches from recent changes for things Coverity has complained about
> 
> John Ferlan (4):
>   qemu: Remove unnecessary check in qemuMonitorJSONGetJobInfoOne
>   test: Return early in testQueryJobs
>   util: Avoid possible error in virCommandMassClose
>   tests: Avoid possible error in testExecRestart

ACK series if you properly deal with error reporting in patches 3 and 4
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list