From nobody Tue Nov 26 22:35:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890327; cv=none; d=zoho.com; s=zohoarc; b=DaAfQaWWZ9mhohQ9fDwxr4hjG5z4nzCVpMKTpDpo16eerXKWqGyikYlZroKHYjPqAJjiSt6jTY4wz3KKwuAbqfZVk7pBsmEBe7UvBjIDJ3+gRRIStnXuvBPO0dGkzKzNqzNf3nFlY9p1QS9524+TnYU20vAxTby4TkrtTXep+Xs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890327; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rWrXxVqTXy1iOxpoc1WHkgitXOUUq604NZE5Agvd3EI=; b=hxE35IURNwkkIai0SpAuTfWYkCvRqfRH2jBcxWGJKDDmARPBRwm/73Hi/9dT0MNHZolFiR5KsNVJDvzdMiwTqCk0qg+BeS7j5C0P+wE9NXkKu8XauyoPcAcTNXabhhVeScIUpQA/Cu4RaX25IQNquBbc/kGcI6g5cMW+3Gf2gEE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890327651787.8069598797234; Tue, 23 Jul 2019 06:58:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E83D308620B; Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31DC7102486E; Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D4CF018045CE; Tue, 23 Jul 2019 13:58:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwI0i029812 for ; Tue, 23 Jul 2019 09:58:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 062715D72E; Tue, 23 Jul 2019 13:58:18 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88D45D704 for ; Tue, 23 Jul 2019 13:58:17 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:08 -0400 Message-Id: <20190723135811.26837-2-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] qemu: Remove unnecessary check in qemuMonitorJSONGetJobInfoOne X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It's already dereffed in the initialization and shouldn't be NULL unless virJSONValueArraySize after a virJSONValueObjectGetArray could return a NULL data entry. Found by Coverity Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index f19dced014..d38b2f2cbe 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -9133,9 +9133,6 @@ qemuMonitorJSONGetJobInfoOne(virJSONValuePtr data) VIR_AUTOPTR(qemuMonitorJobInfo) job =3D NULL; qemuMonitorJobInfoPtr ret =3D NULL; =20 - if (!data) - return NULL; - if (VIR_ALLOC(job) < 0) return NULL; =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue Nov 26 22:35:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890307; cv=none; d=zoho.com; s=zohoarc; b=iNt3v0Q7tIxecvWBYA+xQ1TaqZHXLEcbN3jIs8UKic/kzVQtA/49hg8X+bYFJgLtwEo5y/SqKf2d58TkKBFNHJBPg5aqgEquGv8hNuBq6rrZKP1JNRLfOtSKLRxjdPwE7AzPpp4rbXB5STeOQoD3MtEAJVbhsDOsu/7pmWdWAos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890307; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=w/8+H9w1O+ZNjlAJ9ODA6dxPKvRpokBFRjPAql7ITSo=; b=hAXHIKYO6Hy2v6yiTOYWpIbg+boCOcAEMl6DlsQXB+nYssepbqR+E/biIvX6I7BN2fN2pTT9t3xGWFCYmqimpxSQ684JotGnTTrr3+AFM4NccjDVCs2zoQtSJht0XpNWqNgwXxgM1NT3Q+4CPz0Wfi8vwxe9aAP6C4fplIlsy1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890307825413.1667326310927; Tue, 23 Jul 2019 06:58:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD484C065119; Tue, 23 Jul 2019 13:58:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 915AB60852; Tue, 23 Jul 2019 13:58:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A1B3318045CE; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwKpN029825 for ; Tue, 23 Jul 2019 09:58:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id A55315D704; Tue, 23 Jul 2019 13:58:20 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63C7D6266C for ; Tue, 23 Jul 2019 13:58:18 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:09 -0400 Message-Id: <20190723135811.26837-3-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] test: Return early in testQueryJobs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 23 Jul 2019 13:58:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Avoid the chance that qemuMonitorTestNewSimple could return NULL Found by Coverity Signed-off-by: John Ferlan --- tests/qemumonitorjsontest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 8eb9d2e01b..bf89f49aca 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2959,6 +2959,9 @@ testQueryJobs(const void *opaque) size_t i; int ret =3D -1; =20 + if (!test) + return -1; + if (virAsprintf(&filenameJSON, abs_srcdir "/qemumonitorjsondata/query-jobs-%s.json", data->name) < 0 || --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue Nov 26 22:35:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890331; cv=none; d=zoho.com; s=zohoarc; b=FFoi8AceaZxjpo8z2+Z+kZ4ZZnRnPNjBO8rSt/tJSy4QC6FEiprDBDZmVHYXRQKInV8AdDmTHrIiLBfP0gvOfRv/ebgqbJzvjo2pvogs8ZpPTEUHr6PsL1hfY5sMz0O2njM/ALmuxXE/Gstn4U9BYg6xlrRWhTKGSPlcMhQY8Kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890331; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=N3cekm5AUACouxAHE4yHsDD5TO99qhbXefchKP273TY=; b=ZDNvaYOFTMHXRWo3u6ZPZhDMAGy0y++thJMxYV2MK+Y2yWY8qtFP02IRo5DQ+pqT5IUKV/ENWLeacb87u4GuG4eqCYq5kh3zyFGl6oEVp3tev/SXotEI29CVr9Bis4tXR5+o9kviquKqJMlsXVohTu8bmM8IZevB5FQvHyzMabo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890331015450.7610268570876; Tue, 23 Jul 2019 06:58:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB8FC3084242; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A720910114A1; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6823441F40; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwL3M029832 for ; Tue, 23 Jul 2019 09:58:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1AE665D72E; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEB695D704 for ; Tue, 23 Jul 2019 13:58:20 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:10 -0400 Message-Id: <20190723135811.26837-4-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] util: Avoid possible error in virCommandMassClose X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 23 Jul 2019 13:58:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Avoid the chance that sysconf(_SC_OPEN_MAX) returns -1 and thus would cause virBitmapNew would attempt to allocate a very large bitmap. Found by Coverity Signed-off-by: John Ferlan --- src/util/vircommand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 4501c96bbf..cedbd01446 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -487,7 +487,7 @@ virCommandMassClose(virCommandPtr cmd, * Therefore we can safely allocate memory here (and transitively call * opendir/readdir) without a deadlock. */ =20 - if (!(fds =3D virBitmapNew(openmax))) + if (openmax < 0 || !(fds =3D virBitmapNew(openmax))) return -1; =20 # ifdef __linux__ --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue Nov 26 22:35:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890334; cv=none; d=zoho.com; s=zohoarc; b=S4UKNWBAtmbvE0fRJBLAcMaKS1JrjQgyzfUtBCvgdC+Cd2HWV7MegAqx2POzNU3JKc37/C8/rZ7Rwp+lsoPpRWNVcGkFs+M89q9IZYMSGUD+j9yHpny0ZZBsMgXgPmEoJ/h/deXndGKMkHztt13L5SWkd01WpoiUYhzP1enk300= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890334; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tghKDCYCkJMgjkxF/Qv9zwGuwckH/BXhRnoOYuQ+GWQ=; b=Iae9FsMoL1ZKk8XHFa/KqxBLWBg7CxUIQJ7VHEK90SfcWWYPr1rmY5th4uJKFOOdgoREY9dWOPK6CkveXYZH5LQ+FQGogvJkcsCp6BDkttfCFOzUvGCfWPVLNR3B+Ctsaacf5cpMn0qzV4D9xv4Ptpih3L1lxY8cxdPpLxWk36U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890334448594.1272510080747; Tue, 23 Jul 2019 06:58:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CA11C025019; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45F9D60603; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E86218089C8; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwLJW029837 for ; Tue, 23 Jul 2019 09:58:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 846A35D72E; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43B555D704 for ; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:11 -0400 Message-Id: <20190723135811.26837-5-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] tests: Avoid possible error in testExecRestart X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If the dup2 fails, then we aren't going to get the correct result. Found by Coverity Signed-off-by: John Ferlan --- tests/virnetdaemontest.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index eae630a8f1..d0e9f241e3 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -287,10 +287,11 @@ static int testExecRestart(const void *opaque) * fds 100->103 for something else, which is probably * fairly reasonable in general */ - dup2(fdserver[0], 100); - dup2(fdserver[1], 101); - dup2(fdclient[0], 102); - dup2(fdclient[1], 103); + if (dup2(fdserver[0], 100) < 0 || + dup2(fdserver[1], 101) < 0 || + dup2(fdclient[0], 102) < 0 || + dup2(fdclient[1], 103) < 0) + goto cleanup; =20 if (virAsprintf(&infile, "%s/virnetdaemondata/input-data-%s.json", abs_srcdir, data->jsonfile) < 0) --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list