qemu: remove a redundant call from qemuDomainGetPerfEvents

[libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents

Ilias Stamatis posted 1 patch 6 years, 7 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190701141500.3401-1-stamatis.iliass@gmail.com

src/qemu/qemu_driver.c | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents

Posted by Ilias Stamatis 6 years, 7 months ago

Calling virDomainObjUpdateModificationImpact directly inside the
function body is redundant, since the same function call is embedded
into virDomainObjGetOneDef.

Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
---
 src/qemu/qemu_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ef2e980216..6bfbc31c1c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -10339,9 +10339,6 @@ qemuDomainGetPerfEvents(virDomainPtr dom,
     if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
         goto cleanup;

-    if (virDomainObjUpdateModificationImpact(vm, &flags) < 0)
-        goto endjob;
-
     if (!(def = virDomainObjGetOneDef(vm, flags)))
         goto endjob;

--
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents

Posted by Erik Skultety 6 years, 7 months ago

On Mon, Jul 01, 2019 at 04:15:00PM +0200, Ilias Stamatis wrote:
> Calling virDomainObjUpdateModificationImpact directly inside the
> function body is redundant, since the same function call is embedded
> into virDomainObjGetOneDef.
>
> Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list