From nobody Tue Apr 30 10:31:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1561990562; cv=none; d=zoho.com; s=zohoarc; b=ZJsL8XhQRPYsjrRXyhWuccCHIxcUEbuCv/he5I80JADj5gO7EthrzmTI+dSamjM9PDpE+bN7PJyLhpFWVtzaEYoX95SI+4mTz1olHOPERBPBfAerU95IjloeOBOyekv8Do72OvEvEdrqZfwAWxAFMICCx8eTS652jK6NlWqEThM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561990562; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=0P+ksvcBEoDczhJLCG+RjsPGhuHUdJ/H5x0WvLal/DY=; b=a2UPvi1TqNgTVDwFniE0VABUN8y9dyCe6iuUSAuAsW58QydatH3iaT/04x5R5n5FH16NiTTc4832Nu+zK/CuCKBRXJad/+Z9yzd5UvbwUAm/e6ezz6gjWY1JJKR3kHHu2/6xH8GiNOc5HXkahz1uO0ODvVq/tp/PaF3KwKEv2dw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561990562240776.6950918082464; Mon, 1 Jul 2019 07:16:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 988948762B; Mon, 1 Jul 2019 14:15:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6054717AC9; Mon, 1 Jul 2019 14:15:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A9EB21806B18; Mon, 1 Jul 2019 14:15:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x61EFKME016827 for ; Mon, 1 Jul 2019 10:15:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id B947D17ADA; Mon, 1 Jul 2019 14:15:20 +0000 (UTC) Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1D1C608C2 for ; Mon, 1 Jul 2019 14:15:18 +0000 (UTC) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E10B230C0DC9 for ; Mon, 1 Jul 2019 14:15:04 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id f9so14026583wre.12 for ; Mon, 01 Jul 2019 07:15:04 -0700 (PDT) Received: from archpc.localdomain (x8d1ee222.agdsn.tu-dresden.de. [141.30.226.34]) by smtp.gmail.com with ESMTPSA id q193sm8994686wme.8.2019.07.01.07.15.01 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 07:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=khbuD9pyF73kPu5Dia2QU92yASe7/I4cYAhD4XGRYbY=; b=Io6AVsKy0TjDGubRrlTJIbeE3bJbiErM+nt5yQsv5wDM+TG6BzWdqlwlr7phhSV7sj vS1Nu/ueYfInZyycM/cu2MgEpu0vxZvCyD/bZFx2Go5O2cUaQ5/ZdOs9YDq2/g03m99L 4mTy7XZ80h+DyU4+MrdH5lMhB4PwZ3iLGudsjs4gKj/zJ4ROWgC1FZRzFFnhoDjcLcU6 twXygUd8ghdlb8ZvLQ4BLf/1Nv8Le5gNVQq+reKYwBhl9tDQrDuwDCrmA4j8ReepK12g lgoP51TZ6SqJaIfdU02Tq5IPKl4o/oGi57Mizaa+Pt4bRaOQFMeX6oKM4Lu//J5lj3Tb 5cTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=khbuD9pyF73kPu5Dia2QU92yASe7/I4cYAhD4XGRYbY=; b=b1XoFPIqyzN3iRUokMc+9MsxxTvHgolAQ3CN2eRB8DhkEYHFFX+9j9/Du1Sd08x+jL 4LcXNE1wljAitJ4V0CGHiYloYgSdgvEBhal2RK+lBLSQ9R7iyY95Zdi3Ozz6JvVMnMlH 8T+LAc+Z13nWWkEE0PK8X1hbVLfPZ0hAkyI9vzyQzEH5tJVzQ2xOe4IPNbXqlpvhzPFg ymP7MdKgZBtL+KQkNWx8dKKaTg7mluUb/MAi91gVNCt1+Emyp4jZ1mie2sTaceRlT99Y 0HqZf2BMhQhPEHNNmaadzGf1mwIKBmRsuk6kwAN0bGMcG5rgeaISlER2RSiNPim7/Cn7 /Okw== X-Gm-Message-State: APjAAAWD7HEo/NnIsQ6OJEmOgtJZYH0Yn/eDnbd1hdRU+4ovMsAcL+zk n2GN5yPT6F9jyvdKlhIgBYme9klw2xqmPQ== X-Google-Smtp-Source: APXvYqz438roZTevYGu7A+blaRAgwMlNzeHm8JbPdHs2mZfFvu1EoeB5Bw/bLVj3VzBM0hLt+mya6A== X-Received: by 2002:a5d:668e:: with SMTP id l14mr8558998wru.156.1561990503188; Mon, 01 Jul 2019 07:15:03 -0700 (PDT) From: Ilias Stamatis To: libvir-list@redhat.com Date: Mon, 1 Jul 2019 16:15:00 +0200 Message-Id: <20190701141500.3401-1-stamatis.iliass@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 01 Jul 2019 14:15:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 01 Jul 2019 14:15:05 +0000 (UTC) for IP:'209.85.221.66' DOMAIN:'mail-wr1-f66.google.com' HELO:'mail-wr1-f66.google.com' FROM:'stamatis.iliass@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.299 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.221.66 mail-wr1-f66.google.com 209.85.221.66 mail-wr1-f66.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 01 Jul 2019 14:15:50 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Calling virDomainObjUpdateModificationImpact directly inside the function body is redundant, since the same function call is embedded into virDomainObjGetOneDef. Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ef2e980216..6bfbc31c1c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10339,9 +10339,6 @@ qemuDomainGetPerfEvents(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) - goto endjob; - if (!(def =3D virDomainObjGetOneDef(vm, flags))) goto endjob; -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list