[libvirt] [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces

Daniel P. Berrangé posted 4 patches 4 years, 9 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190626155443.7038-1-berrange@redhat.com
There is a newer version of this series
docs/hvsupport.pl           | 44 ++++++++++++-------------------------
docs/libvirt.css            | 10 ---------
include/libvirt/virterror.h |  1 -
src/qemu/qemu_driver.c      | 31 --------------------------
src/util/virerror.c         |  4 ----
5 files changed, 14 insertions(+), 76 deletions(-)
[libvirt] [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces
Posted by Daniel P. Berrangé 4 years, 9 months ago
A deprecation is inherantly a warning, not an error, so adding an error
with this name makes no conceptual sense.

Features in drivers may come & go at any time and we've always use the
VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support
a particular API.

Daniel P. Berrangé (4):
  qemu: delete methods which are no longer supported
  Revert "error: Add VIR_ERR_DEPRECATED error code"
  Revert "docs: css: Add style for <span class='deprecated'> ..."
  Revert "docs: hvsupport: Add support for deprecating hypervisor
    implementations"

 docs/hvsupport.pl           | 44 ++++++++++++-------------------------
 docs/libvirt.css            | 10 ---------
 include/libvirt/virterror.h |  1 -
 src/qemu/qemu_driver.c      | 31 --------------------------
 src/util/virerror.c         |  4 ----
 5 files changed, 14 insertions(+), 76 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces
Posted by Ján Tomko 4 years, 9 months ago
On Wed, Jun 26, 2019 at 04:54:39PM +0100, Daniel P. Berrangé wrote:
>A deprecation is inherantly a warning, not an error, so adding an error
>with this name makes no conceptual sense.
>
>Features in drivers may come & go at any time and we've always use the
>VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support
>a particular API.
>
>Daniel P. Berrangé (4):
>  qemu: delete methods which are no longer supported
>  Revert "error: Add VIR_ERR_DEPRECATED error code"
>  Revert "docs: css: Add style for <span class='deprecated'> ..."
>  Revert "docs: hvsupport: Add support for deprecating hypervisor
>    implementations"
>
> docs/hvsupport.pl           | 44 ++++++++++++-------------------------
> docs/libvirt.css            | 10 ---------
> include/libvirt/virterror.h |  1 -
> src/qemu/qemu_driver.c      | 31 --------------------------
> src/util/virerror.c         |  4 ----
> 5 files changed, 14 insertions(+), 76 deletions(-)
>

Missing a revert of:
commit 3026f6d9d986ad63c4b4a1c57589e6d05b71bd70
    news: Mention VIR_ERR_DEPRECATED in improvements

I wish it would have been the first news revert in this release cycle.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list