From nobody Fri May 3 12:52:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561564606; cv=none; d=zoho.com; s=zohoarc; b=mLtgqM8rFY3n56nrnIVjehCdfzNgFs5h2gxNpzvCWv/jZVlKwcw+vU9eeMr48BAtgMTUtHg2tWLa/Dn2Fo+5mIYdsVGu4x75+oYCSJ+AgAn7RUe9RmCPHhjAjL0L/eLjxffP18Euf2B4+p3QP44WWiVwvp8We8BXfK/O0j+v1hw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561564606; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rUFdg1Ej6BLnBH/qqm5T1sZ3O2DWMejZDIEj2lGbmJE=; b=mVoqmwOn/QDhJlXdppDq3kFAbQUa7ZqTUkfzRCMubbrnWZTiUohRB+0H6dHuXKnebF3TZm9f6BCQAKrsPRKAcbb2+s1+WWWJSXJapn2XkX/hobG46sptA1AbcJLAcAP1k1Sv4LR93kh9R+bZxMwxBhfyQFaP68GkW4v1/fFY63A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561564606559208.002276723695; Wed, 26 Jun 2019 08:56:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 128955F79B; Wed, 26 Jun 2019 15:56:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D91391001B1A; Wed, 26 Jun 2019 15:56:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 877191806B15; Wed, 26 Jun 2019 15:56:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5QFsniY023820 for ; Wed, 26 Jun 2019 11:54:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id B7E975D71B; Wed, 26 Jun 2019 15:54:49 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9A0E5471C; Wed, 26 Jun 2019 15:54:48 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 26 Jun 2019 16:54:40 +0100 Message-Id: <20190626155443.7038-2-berrange@redhat.com> In-Reply-To: <20190626155443.7038-1-berrange@redhat.com> References: <20190626155443.7038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] qemu: delete methods which are no longer supported X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 26 Jun 2019 15:56:45 +0000 (UTC) The public API entry points will report VIR_ERR_NO_SUPPORT to the caller when a driver does not provide an implementation of a particular method. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d6ab134196..595a381734 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7316,22 +7316,6 @@ static char } =20 =20 -static char * -qemuConnectDomainXMLFromNative(virConnectPtr conn, - const char *format ATTRIBUTE_UNUSED, - const char *config ATTRIBUTE_UNUSED, - unsigned int flags) -{ - virCheckFlags(0, NULL); - - if (virConnectDomainXMLFromNativeEnsureACL(conn) < 0) - return NULL; - - virReportError(VIR_ERR_DEPRECATED, "%s", - _("converting arbitrary QEMU command lines to libvirt d= omain XML is no longer supported")); - return NULL; -} - static char *qemuConnectDomainXMLToNative(virConnectPtr conn, const char *format, const char *xmlData, @@ -16772,19 +16756,6 @@ static int qemuDomainQemuMonitorCommand(virDomainP= tr domain, const char *cmd, } =20 =20 -static virDomainPtr -qemuDomainQemuAttach(virConnectPtr conn ATTRIBUTE_UNUSED, - unsigned int pid_value ATTRIBUTE_UNUSED, - unsigned int flags) -{ - virCheckFlags(0, NULL); - - virReportError(VIR_ERR_DEPRECATED, "%s", - _("attaching to a QEMU process started outside of libvi= rt is no longer supported")); - return NULL; -} - - static int qemuDomainOpenConsole(virDomainPtr dom, const char *dev_name, @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver =3D= { .domainGetSecurityLabelList =3D qemuDomainGetSecurityLabelList, /* 0.1= 0.0 */ .nodeGetSecurityModel =3D qemuNodeGetSecurityModel, /* 0.6.1 */ .domainGetXMLDesc =3D qemuDomainGetXMLDesc, /* 0.2.0 */ - .connectDomainXMLFromNative =3D qemuConnectDomainXMLFromNative, /* 0.6= .4 (deprecated: 5.5.0) */ .connectDomainXMLToNative =3D qemuConnectDomainXMLToNative, /* 0.6.4 */ .connectListDefinedDomains =3D qemuConnectListDefinedDomains, /* 0.2.0= */ .connectNumOfDefinedDomains =3D qemuConnectNumOfDefinedDomains, /* 0.2= .0 */ @@ -22356,7 +22326,6 @@ static virHypervisorDriver qemuHypervisorDriver =3D= { .domainRevertToSnapshot =3D qemuDomainRevertToSnapshot, /* 0.8.0 */ .domainSnapshotDelete =3D qemuDomainSnapshotDelete, /* 0.8.0 */ .domainQemuMonitorCommand =3D qemuDomainQemuMonitorCommand, /* 0.8.3 */ - .domainQemuAttach =3D qemuDomainQemuAttach, /* 0.9.4 (deprecated: 5.5.= 0) */ .domainQemuAgentCommand =3D qemuDomainQemuAgentCommand, /* 0.10.0 */ .connectDomainQemuMonitorEventRegister =3D qemuConnectDomainQemuMonito= rEventRegister, /* 1.2.3 */ .connectDomainQemuMonitorEventDeregister =3D qemuConnectDomainQemuMoni= torEventDeregister, /* 1.2.3 */ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri May 3 12:52:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561564632; cv=none; d=zoho.com; s=zohoarc; b=cc7/Uw5WKg7ZY+IarSRXYK5ZqBui3z+V0WfYZ9+yiGIpm8vw3LGQ4pbyOT+fI74yVOkUA4ZR+Cr5q2YMeGJzgFAYZIAtDHu0RQpG8k5YT8QphnnOTXXLIe3BzsjJyZjMwZ42ULjaNRFJ72PtJVQhS2ts4Ss8nuwCAgK9XJvBi0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561564632; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=q7ao+gxj/LAwigFTsUkRxDLqZLOxOYlAaXV2G2zrEjE=; b=KwW9oYn/lTNqwpmC53V++JL65Vy2LfcUP5dhgVgrKXJ7u4/t2RvFHNS6wYcMUshTrM9sYVGj7M+0hV0y1ud60YI7LX1HYxDm25iNL7Oje4QO4gU5/wVsFozeCzVpwkzvCZtg5hw/WEpghbEkIcQSOn/TrNrffCdQ+4x6O1n/70M= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561564632236662.89088182418; Wed, 26 Jun 2019 08:57:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 022D7C18B2D6; Wed, 26 Jun 2019 15:57:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D086A5D9E1; Wed, 26 Jun 2019 15:56:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 86B3C1806B12; Wed, 26 Jun 2019 15:56:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5QFspRN023854 for ; Wed, 26 Jun 2019 11:54:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 017845D71D; Wed, 26 Jun 2019 15:54:51 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27D955D71B; Wed, 26 Jun 2019 15:54:49 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 26 Jun 2019 16:54:41 +0100 Message-Id: <20190626155443.7038-3-berrange@redhat.com> In-Reply-To: <20190626155443.7038-1-berrange@redhat.com> References: <20190626155443.7038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 26 Jun 2019 15:57:11 +0000 (UTC) This reverts commit 226094fbc483128c8888f4171c353aed738b8346. A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature. A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For features which are entirely absent we already document that the VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish between a feature which never existed and a feature which previously existed and was since removed. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- include/libvirt/virterror.h | 1 - src/util/virerror.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 22bc3c2d27..102a2573bf 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -329,7 +329,6 @@ typedef enum { VIR_ERR_INVALID_NETWORK_PORT =3D 105, /* invalid network port object */ VIR_ERR_NETWORK_PORT_EXIST =3D 106, /* the network port already exis= t */ VIR_ERR_NO_NETWORK_PORT =3D 107, /* network port not found */ - VIR_ERR_DEPRECATED =3D 108, /* configuration or operation is= no longer supported */ =20 # ifdef VIR_ENUM_SENTINELS VIR_ERR_NUMBER_LAST diff --git a/src/util/virerror.c b/src/util/virerror.c index 26f14ddd29..dfba8c5712 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1235,10 +1235,6 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NU= MBER_LAST] =3D { [VIR_ERR_NO_NETWORK_PORT] =3D { N_("network port not found"), N_("network port not found: %s") }, - [VIR_ERR_DEPRECATED] =3D { - N_("operation or configuration no longer supported"), - "%s", - }, }; =20 =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri May 3 12:52:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561564536; cv=none; d=zoho.com; s=zohoarc; b=FufBELyHQpv8aPznyv73QzS8A9nf7Ut+X7dHv+w2Gw0o4N1t1BfSEN8G+TRGqRl1P3P8FXGW858PKqOGwklhCkDBBFkxIBDHf5Q2unfmSLtgXvy+RvanH88+iXJYjh7YCB6YkS0Uv9oE+p5oHuagzQz4xfecEGQaPq/a+0Uq3Ak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561564536; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=HhsRutRGRDHUFwn9TZ9s3R1Wghi3P5EFmnPQRIGpHaY=; b=TXeC+E28APyib+GkkqMXtVt68qU0Zr39Hqhptnp6E2o5dd9rGi3MW9y83O4A6uoRkIprcz+KO/RJIQK5F/8FNgYva2sNGht+VBVEhHYJR2lcRJOnmj2d0N49Njix9dN8dcOcppx1ZohYPlTNMMtR2QZ8YgEUIIHMislDOW6ZQFY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561564536548182.20631586130548; Wed, 26 Jun 2019 08:55:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9277A3071524; Wed, 26 Jun 2019 15:55:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 139891001B10; Wed, 26 Jun 2019 15:55:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C5AD1806B0F; Wed, 26 Jun 2019 15:54:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5QFsqA0023885 for ; Wed, 26 Jun 2019 11:54:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 079FF5D71C; Wed, 26 Jun 2019 15:54:52 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C6E25D71B; Wed, 26 Jun 2019 15:54:51 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 26 Jun 2019 16:54:42 +0100 Message-Id: <20190626155443.7038-4-berrange@redhat.com> In-Reply-To: <20190626155443.7038-1-berrange@redhat.com> References: <20190626155443.7038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] Revert "docs: css: Add style for ..." X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 26 Jun 2019 15:55:35 +0000 (UTC) This reverts commit 71626402f481ed47ff67dafa8521b01a42625707. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- docs/libvirt.css | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index 6639b1df64..54d015db98 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -274,12 +274,6 @@ span.since { font-weight: bold; } =20 -span.deprecated { - color: darkred; - font-style: italic; - font-weight: bold; -} - img.diagram { background: rgb(230,230,230); border: 2px dotted rgb(178,178,178); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri May 3 12:52:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561564600; cv=none; d=zoho.com; s=zohoarc; b=iopMdSinTL1s2bv6zG5aQykkuUXm0c3nlrnuh1Oeh1KpMAkY+iTDSOoSc0ftrEwuk69OQzWBEwHS6fNZ5iApacGoU0jaTgaqUL2LbKgvnJi30RoUoWDEgcPVYS0Ct6skbelmOozP6MVnrC2EWZxPuzbHPBQB/ACypi74eArf3IM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561564600; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GXU1ZwVJsO0wJc01f8NznMZIWztxawogdwnKZ0spX2g=; b=iWJslSEGxuK6dhbz1Cj76nVq99sZ4GHNEUzQhJJuHUSDbYmmHxlb4446T9rgLe1rXnyNX5YJ/hAZgYmjzoWy83amsDxmRSgNwi4CoRZzfgSkf+2T0fA6oT2g+2O8gt+zLGKACZH+qBqo7j85XkmJZ/XxV2w91fAQGFjQW7PYXXs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561564600444425.2904732336858; Wed, 26 Jun 2019 08:56:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1306E3082A24; Wed, 26 Jun 2019 15:56:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD10D60143; Wed, 26 Jun 2019 15:56:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6B7CD206D4; Wed, 26 Jun 2019 15:56:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5QFsrrV023917 for ; Wed, 26 Jun 2019 11:54:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 30D345D71D; Wed, 26 Jun 2019 15:54:53 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 482A65D71C; Wed, 26 Jun 2019 15:54:52 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 26 Jun 2019 16:54:43 +0100 Message-Id: <20190626155443.7038-5-berrange@redhat.com> In-Reply-To: <20190626155443.7038-1-berrange@redhat.com> References: <20190626155443.7038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] Revert "docs: hvsupport: Add support for deprecating hypervisor implementations" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 26 Jun 2019 15:56:39 +0000 (UTC) This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- docs/hvsupport.pl | 44 ++++++++++++++------------------------------ docs/libvirt.css | 4 ---- 2 files changed, 14 insertions(+), 34 deletions(-) diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl index 2ea245e83a..a2b980c502 100755 --- a/docs/hvsupport.pl +++ b/docs/hvsupport.pl @@ -234,11 +234,10 @@ foreach my $src (@srcs) { } =20 } else { - if ($line =3D~ m!\s*\.(\w+)\s*=3D\s*(\w+)\s*,?\s*(?:/\*\s*(\d+= \.\d+\.\d+)\s*(?:\(deprecated:\s*(\d+\.\d+\.\d+)\))?\s*\*/\s*)?$!) { + if ($line =3D~ m!\s*\.(\w+)\s*=3D\s*(\w+)\s*,?\s*(?:/\*\s*(\d+= \.\d+\.\d+)\s*\*/\s*)?$!) { my $api =3D $1; my $meth =3D $2; my $vers =3D $3; - my $depre =3D $4; =20 next if $api eq "no" || $api eq "name"; =20 @@ -252,16 +251,12 @@ foreach my $src (@srcs) { die "Found unexpected method $api in $ingrp\n"; } =20 - $groups{$ingrp}->{drivers}->{$impl}->{$api} =3D {}; - $groups{$ingrp}->{drivers}->{$impl}->{$api}->{vers} =3D $v= ers; - $groups{$ingrp}->{drivers}->{$impl}->{$api}->{depre} =3D = $depre; + $groups{$ingrp}->{drivers}->{$impl}->{$api} =3D $vers; if ($api eq "domainMigratePrepare" || $api eq "domainMigratePrepare2" || $api eq "domainMigratePrepare3") { - if (!$groups{$ingrp}->{drivers}->{$impl}->{"domainMigr= ate"}) { - $groups{$ingrp}->{drivers}->{$impl}->{"domainMigra= te"} =3D {}; - $groups{$ingrp}->{drivers}->{$impl}->{"domainMigra= te"}->{vers} =3D $vers; - } + $groups{$ingrp}->{drivers}->{$impl}->{"domainMigrate"}= =3D $vers + unless $groups{$ingrp}->{drivers}->{$impl}->{"doma= inMigrate"}; } =20 } elsif ($line =3D~ /}/) { @@ -285,7 +280,7 @@ $groups{virHypervisorDriver}->{apis}->{"domainMigrate"}= =3D "virDomainMigrate"; my $openAuthVers =3D (0 * 1000 * 1000) + (4 * 1000) + 0; =20 foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) { - my $openVersStr =3D $groups{"virHypervisorDriver"}->{drivers}->{$drv}-= >{"connectOpen"}->{vers}; + my $openVersStr =3D $groups{"virHypervisorDriver"}->{drivers}->{$drv}-= >{"connectOpen"}; my $openVers; if ($openVersStr =3D~ /(\d+)\.(\d+)\.(\d+)/) { $openVers =3D ($1 * 1000 * 1000) + ($2 * 1000) + $3; @@ -295,16 +290,14 @@ foreach my $drv (keys %{$groups{"virHypervisorDriver"= }->{drivers}}) { $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenReadOn= ly"} =3D $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpen"}; =20 - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAuth"}= =3D {}; - # virConnectOpenAuth is always 0.4.0 if the driver existed # before this time, otherwise it matches the version of # the driver's virConnectOpen entry if ($openVersStr eq "Y" || $openVers >=3D $openAuthVers) { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAu= th"}->{vers} =3D $openVersStr; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAu= th"} =3D $openVersStr; } else { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAu= th"}->{vers} =3D "0.4.0"; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpenAu= th"} =3D "0.4.0"; } } =20 @@ -316,23 +309,21 @@ $groups{virHypervisorDriver}->{apis}->{"domainCreateL= inux"} =3D "virDomainCreateLi my $createAPIVers =3D (0 * 1000 * 1000) + (0 * 1000) + 3; =20 foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) { - my $createVersStr =3D $groups{"virHypervisorDriver"}->{drivers}->{$drv= }->{"domainCreateXML"}->{vers}; + my $createVersStr =3D $groups{"virHypervisorDriver"}->{drivers}->{$drv= }->{"domainCreateXML"}; next unless defined $createVersStr; my $createVers; if ($createVersStr =3D~ /(\d+)\.(\d+)\.(\d+)/) { $createVers =3D ($1 * 1000 * 1000) + ($2 * 1000) + $3; } =20 - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateLinux= "} =3D {}; - # virCreateLinux is always 0.0.3 if the driver existed # before this time, otherwise it matches the version of # the driver's virCreateXML entry if ($createVersStr eq "Y" || $createVers >=3D $createAPIVers) { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateL= inux"}->{vers} =3D $createVersStr; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateL= inux"} =3D $createVersStr; } else { - $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateL= inux"}->{vers} =3D "0.0.3"; + $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"domainCreateL= inux"} =3D "0.0.3"; } } =20 @@ -351,9 +342,7 @@ print < This page documents which libvirt calls work on which libvirt drivers / hypervisors, and which version the API appeared -in. If a hypervisor driver deprecated the API, the version when it -was removed is also mentioned (highlighted in -dark red). +in.

=20 EOF @@ -406,16 +395,11 @@ EOF EOF =20 foreach my $drv (sort {$a cmp $b } keys %{$groups{$grp}->{drivers}= }) { - print ""; if (exists $groups{$grp}->{drivers}->{$drv}->{$field}) { - if ($groups{$grp}->{drivers}->{$drv}->{$field}->{vers}) { - print $groups{$grp}->{drivers}->{$drv}->{$field}->{ver= s}; - } - if ($groups{$grp}->{drivers}->{$drv}->{$field}->{depre}) { - print " - ", $groups{$g= rp}->{drivers}->{$drv}->{$field}->{depre}, ""; - } + print "", $groups{$grp}->{drivers}->{$drv}->{$field}, = "\n"; + } else { + print "\n"; } - print "\n"; } =20 print <