[libvirt] [PATCH v2 2/4] conf: fix leak of directory handle when loading network ports

Daniel P. Berrangé posted 4 patches 6 years, 7 months ago
[libvirt] [PATCH v2 2/4] conf: fix leak of directory handle when loading network ports
Posted by Daniel P. Berrangé 6 years, 7 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/conf/virnetworkobj.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
index 47c142998e..ed1f02f4c5 100644
--- a/src/conf/virnetworkobj.c
+++ b/src/conf/virnetworkobj.c
@@ -1750,6 +1750,7 @@ virNetworkObjDeleteAllPorts(virNetworkObjPtr net,
 
     ret = 0;
  cleanup:
+    VIR_DIR_CLOSE(dh);
     return ret;
 }
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 2/4] conf: fix leak of directory handle when loading network ports
Posted by John Ferlan 6 years, 7 months ago

On 6/18/19 1:39 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/conf/virnetworkobj.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
> index 47c142998e..ed1f02f4c5 100644
> --- a/src/conf/virnetworkobj.c
> +++ b/src/conf/virnetworkobj.c
> @@ -1750,6 +1750,7 @@ virNetworkObjDeleteAllPorts(virNetworkObjPtr net,
>  

Just need to initialize dh = NULL

John

>      ret = 0;
>   cleanup:
> +    VIR_DIR_CLOSE(dh);
>      return ret;
>  }
>  
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list