Misc fixes to network port code

[libvirt] [PATCH v2 0/4] Misc fixes to network port code

Daniel P. Berrangé posted 4 patches 4 years, 10 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190618173921.22902-1-berrange@redhat.com

src/conf/domain_conf.c       | 12 ++++++++++--
src/conf/virnetworkobj.c     |  9 ++++++---
src/conf/virnetworkportdef.c | 26 +++++++++-----------------
3 files changed, 25 insertions(+), 22 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/4] Misc fixes to network port code

Posted by Daniel P. Berrangé 4 years, 10 months ago

Fixes for bugs spotted by coverity

Daniel P. Berrangé (4):
  conf: fix leak when parsing network port XML
  conf: fix leak of directory handle when loading network ports
  conf: fix NULL deref when exporting ports
  conf: add error checking of UUID generation

 src/conf/domain_conf.c       | 12 ++++++++++--
 src/conf/virnetworkobj.c     |  9 ++++++---
 src/conf/virnetworkportdef.c | 26 +++++++++-----------------
 3 files changed, 25 insertions(+), 22 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] Misc fixes to network port code

Posted by John Ferlan 4 years, 10 months ago


On 6/18/19 1:39 PM, Daniel P. Berrangé wrote:
> Fixes for bugs spotted by coverity
> 
> Daniel P. Berrangé (4):
>   conf: fix leak when parsing network port XML
>   conf: fix leak of directory handle when loading network ports
>   conf: fix NULL deref when exporting ports
>   conf: add error checking of UUID generation
> 
>  src/conf/domain_conf.c       | 12 ++++++++++--
>  src/conf/virnetworkobj.c     |  9 ++++++---
>  src/conf/virnetworkportdef.c | 26 +++++++++-----------------
>  3 files changed, 25 insertions(+), 22 deletions(-)
> 

Fix the nit in 2 and that makes coverity happy again...

Thanks

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list