snapshot: Improve message for VIR_ERR_INVALID_DOMAIN_SNAPSHOT

[libvirt] [PATCH] snapshot: Improve message for VIR_ERR_INVALID_DOMAIN_SNAPSHOT

Posted by Eric Blake 5 years, 1 month ago

For consistency with other error messages, and the fact that
the object is always called a virDomainSnapshot rather than
a mere virSnapshot, include the word "domain" in the error
message.

Suggested-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
 src/util/virerror.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virerror.c b/src/util/virerror.c
index 9e3975fe76..05e535d859 100644
--- a/src/util/virerror.c
+++ b/src/util/virerror.c
@@ -1123,8 +1123,8 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NUMBER_LAST] = {
         N_("Hook script execution failed"),
         N_("Hook script execution failed: %s") },
     [VIR_ERR_INVALID_DOMAIN_SNAPSHOT] = {
-        N_("Invalid snapshot"),
-        N_("Invalid snapshot: %s") },
+        N_("Invalid domain snapshot"),
+        N_("Invalid domain snapshot: %s") },
     [VIR_ERR_NO_DOMAIN_SNAPSHOT] = {
         N_("Domain snapshot not found"),
         N_("Domain snapshot not found: %s") },
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] snapshot: Improve message for VIR_ERR_INVALID_DOMAIN_SNAPSHOT

Posted by Daniel P. Berrangé 5 years, 1 month ago

On Mon, Feb 25, 2019 at 10:40:00AM -0600, Eric Blake wrote:
> For consistency with other error messages, and the fact that
> the object is always called a virDomainSnapshot rather than
> a mere virSnapshot, include the word "domain" in the error
> message.
> 
> Suggested-by: John Ferlan <jferlan@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  src/util/virerror.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] snapshot: Improve message for VIR_ERR_INVALID_DOMAIN_SNAPSHOT

Posted by Eric Blake 5 years, 1 month ago

On 2/25/19 10:49 AM, Daniel P. Berrangé wrote:
> On Mon, Feb 25, 2019 at 10:40:00AM -0600, Eric Blake wrote:
>> For consistency with other error messages, and the fact that
>> the object is always called a virDomainSnapshot rather than
>> a mere virSnapshot, include the word "domain" in the error
>> message.
>>
>> Suggested-by: John Ferlan <jferlan@redhat.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>  src/util/virerror.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

I'm assuming this one is safe for freeze, so I pushed it.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list