From nobody Sun May 5 09:56:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1551113039174978.4179431362195; Mon, 25 Feb 2019 08:43:59 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09E3D87649; Mon, 25 Feb 2019 16:43:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 870E760BF4; Mon, 25 Feb 2019 16:43:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B44A4181A00B; Mon, 25 Feb 2019 16:43:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1PGe8tR010270 for ; Mon, 25 Feb 2019 11:40:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6F11A60865; Mon, 25 Feb 2019 16:40:08 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-222.phx2.redhat.com [10.3.116.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C05A60857; Mon, 25 Feb 2019 16:40:03 +0000 (UTC) From: Eric Blake To: libvir-list@redhat.com Date: Mon, 25 Feb 2019 10:40:00 -0600 Message-Id: <20190225164000.21040-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] snapshot: Improve message for VIR_ERR_INVALID_DOMAIN_SNAPSHOT X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 25 Feb 2019 16:43:57 +0000 (UTC) Content-Type: text/plain; charset="utf-8" For consistency with other error messages, and the fact that the object is always called a virDomainSnapshot rather than a mere virSnapshot, include the word "domain" in the error message. Suggested-by: John Ferlan Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrang=C3=A9 --- src/util/virerror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 9e3975fe76..05e535d859 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1123,8 +1123,8 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NUM= BER_LAST] =3D { N_("Hook script execution failed"), N_("Hook script execution failed: %s") }, [VIR_ERR_INVALID_DOMAIN_SNAPSHOT] =3D { - N_("Invalid snapshot"), - N_("Invalid snapshot: %s") }, + N_("Invalid domain snapshot"), + N_("Invalid domain snapshot: %s") }, [VIR_ERR_NO_DOMAIN_SNAPSHOT] =3D { N_("Domain snapshot not found"), N_("Domain snapshot not found: %s") }, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list