[libvirt] [libvirt-python PATCH 2/3] Add missing virPyDictToTypedParams for libvirt_virDomainBlockCopy

John Ferlan posted 3 patches 7 years, 2 months ago
There is a newer version of this series
[libvirt] [libvirt-python PATCH 2/3] Add missing virPyDictToTypedParams for libvirt_virDomainBlockCopy
Posted by John Ferlan 7 years, 2 months ago
Need to free params like similar API's such as libvirt_virDomainMigrate3
and libvirt_virDomainMigrateToURI3.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 libvirt-override.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libvirt-override.c b/libvirt-override.c
index 761b71b..0353306 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -8784,6 +8784,7 @@ libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE_UNUSED,
     c_retval = virDomainBlockCopy(dom, disk, destxml, params, nparams, flags);
     LIBVIRT_END_ALLOW_THREADS;
 
+    virTypedParamsFree(params, nparams);
     return libvirt_intWrap(c_retval);
 }
 
-- 
2.17.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-python PATCH 2/3] Add missing virPyDictToTypedParams for libvirt_virDomainBlockCopy
Posted by Pavel Hrdina 7 years, 2 months ago
On Tue, Nov 20, 2018 at 11:17:11AM -0500, John Ferlan wrote:
> Need to free params like similar API's such as libvirt_virDomainMigrate3
> and libvirt_virDomainMigrateToURI3.
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  libvirt-override.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list